Attachment 69281 Details for Bug 19678 – Bug 19678: Clicking Cancel when adding New Course to course reserves shows message Invalid Course!

[patch] Bug 19678: Clicking Cancel when adding New Course to course reserves shows message Invalid Course!

Bug-19678-Clicking-Cancel-when-adding-New-Course-t.patch (text/plain), 1.90 KB, created by Owen Leonard on 2017-11-22 14:59:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2017-11-22 14:59:31 UTC

Size: 1.90 KB

patch

obsolete

>From 4a15d60743472472565cc80a07f62735bbdadd4d Mon Sep 17 00:00:00 2001
>From: Claire Gravely <claire.gravely@bsz-bw.de>
>Date: Wed, 22 Nov 2017 13:54:11 +0000
>Subject: [PATCH] Bug 19678: Clicking Cancel when adding New Course to course
> reserves shows message Invalid Course!
>
>Clicking on the cancel link when adding a new course to course reserves
>displays the message 'Invalid Course!'. It would be better if it
>redirected back to the main Course Reserves page.
>
>This patch redirects the user back to the main course reserves page.
>
>To Test:
>
>1. Go to Course Reserves
>
>2. Click '+ New Course'
>
>3. Cancel the process
>
>4. You are shown 'Invalid Course!'
>
>5. Apply patch and repeat steps 1-3
>
>6. You are redirected back to the main course reserves page
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt
>index 1a3e01e..a886ce8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt
>@@ -168,7 +168,11 @@
>                 <fieldset class="action">
>                     <input type="submit" value="Save" class="submit" />
> 
>-                    <a href="/cgi-bin/koha/course_reserves/course-details.pl?course_id=[% course_id %]" class="cancel">Cancel</a>
>+                    [% IF course_id %]
>+                        <a href="/cgi-bin/koha/course_reserves/course-details.pl?course_id=[% course_id %]" class="cancel">Cancel</a>
>+                    [% ELSE %]
>+                        <a href="/cgi-bin/koha/course_reserves/course-reserves.pl" class="cancel">Cancel</a>
>+                    [% END %]
>                 </fieldset>
>             </form>
>         </div>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19678: 69277 | 69278 | 69280 | 69281 | 69916