Bugzilla – Attachment 69473 Details for
Bug 19738
XSS in serials module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19738: Fix XSS on vendor name in serials module
Bug-19738-Fix-XSS-on-vendor-name-in-serials-module.patch (text/plain), 2.80 KB, created by
Josef Moravec
on 2017-12-03 22:30:57 UTC
(
hide
)
Description:
Bug 19738: Fix XSS on vendor name in serials module
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2017-12-03 22:30:57 UTC
Size:
2.80 KB
patch
obsolete
>From 35646b103db4f3c475048ddd26265c471f765346 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Sun, 3 Dec 2017 22:21:57 +0000 >Subject: [PATCH] Bug 19738: Fix XSS on vendor name in serials module > >Test plan: > >1) do not apply this patch >2) Have at least one vendor which name does contain javascript, for >example: <i>Vendor 1</i><script>alert('Hi');</script> >3) go to serial module and create new subscription >4) use "Search for vendor" >5) Search for your vendor, when search results table is presented, the >javascript is executed >6) go through subscription creation and save the new subscription >7) On subscription detail page, the javascript is executed as well >8) apply this patch >9) Repeat 3-7, the script is not executed, the input is escaped >--- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search-result.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search-result.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search-result.tt >index ccd6cfa..7e65a26 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search-result.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search-result.tt >@@ -42,7 +42,7 @@ $(document).ready(function(){ > </tr> > [% FOREACH loop_supplier IN loop_suppliers %] > <tr> >- <td>[% loop_supplier.name %]</td> >+ <td>[% loop_supplier.name |html%]</td> > <td><a class="btn btn-default btn-xs select_vendor" href="#" data-vendorid="[% loop_supplier.aqbooksellerid %]" data-vendorname="[% loop_supplier.name |html%]">Choose</a></td> > </tr> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >index 670a9c0..a160fc8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >@@ -87,7 +87,7 @@ $(document).ready(function() { > <ol> > <li><span class="label">Subscription ID: </span>[% subscriptionid %]</li> > <li><span class="label">Librarian identity:</span> [% librarian %]</li> >- <li><span class="label">Vendor:</span> <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% aqbooksellerid %]">[% aqbooksellername %]</a></li> >+ <li><span class="label">Vendor:</span> <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% aqbooksellerid %]">[% aqbooksellername |html %]</a></li> > <li><span class="label">Biblio:</span> <a href="/cgi-bin/koha/catalogue/[% default_bib_view %].pl?biblionumber=[% bibnum %]">[% bibliotitle %]</a> <i>([% bibnum %])</i></li> > [% IF ( OPACBaseURL ) %] > <li> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19738
:
69473
|
70165
|
70321