Attachment 695 Details for Bug 2505 – Patch for members/boraccount.pl and members/pay.pl

[patch] Patch for members/boraccount.pl and members/pay.pl

0013-Bug-2505-Enabled-warnings-in-boraccount.pl-and-pay.patch (text/plain), 1.67 KB, created by Chris Cormack on 2009-09-04 15:57:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2009-09-04 15:57:00 UTC

Size: 1.67 KB

patch

obsolete

>From ac67bdfc2cfa20eec2893d4a7e314f3f11fb2766 Mon Sep 17 00:00:00 2001
>From: Garry Collum <gcollum@gmail.com>
>Date: Fri, 4 Sep 2009 11:58:56 -0400
>Subject: [PATCH] Bug 2505: Enabled warnings in boraccount.pl and pay.pl.
>Content-Type: text/plain; charset="utf-8"
>
>Enabled warnings in members/boraccount.pl and members/pay.pl.  Fixed resulting warnings.
>---
> members/boraccount.pl |    6 +++++-
> members/pay.pl        |    4 +++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/members/boraccount.pl b/members/boraccount.pl
>index cfe40c1..9417ab9 100755
>--- a/members/boraccount.pl
>+++ b/members/boraccount.pl
>@@ -23,6 +23,8 @@
> # Suite 330, Boston, MA  02111-1307 USA
> 
> use strict;
>+use warnings;
>+
> use C4::Auth;
> use C4::Output;
> use C4::Dates qw/format_date/;
>@@ -44,10 +46,12 @@ my ($template, $loggedinuser, $cookie)
>                             });
> 
> my $borrowernumber=$input->param('borrowernumber');
>+my $action = $input->param('action') || '';
>+
> #get borrower details
> my $data=GetMember($borrowernumber,'borrowernumber');
> 
>-if ( $input->param('action') eq 'reverse' ) {
>+if ( $action eq 'reverse' ) {
>   ReversePayment( $borrowernumber, $input->param('accountno') );
> }
> 
>diff --git a/members/pay.pl b/members/pay.pl
>index f19f5b8..02bb683 100755
>--- a/members/pay.pl
>+++ b/members/pay.pl
>@@ -26,6 +26,8 @@
> =cut
> 
> use strict;
>+use warnings;
>+
> use C4::Context;
> use C4::Auth;
> use C4::Output;
>@@ -82,7 +84,7 @@ for ( my $i = 0 ; $i < @names ; $i++ ) {
>         $check = 2;
>     }
> }
>-my $total = $input->param('total');
>+my $total = $input->param('total') || '';
> if ( $check == 0 ) {
>     if ( $total ne '' ) {
>         recordpayment( $borrowernumber, $total );
>-- 
>1.5.6.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 2505: 686 | 687 | 688 | 689 | 690 | 691 | 692 | 693 | 694 | 695 | 696 | 697 | 698 | 699 | 700 | 701 | 702 | 703 | 704 | 705 | 706 | 707 | 708 | 709 | 2223 | 3884 | 4574 | 8209 | 8317 | 8322 | 8373 | 9034 | 9035 | 9036 | 34442