Attachment 69528 Details for Bug 15707 – Bug 15707 - Display error if group title is already used

[patch] Bug 15707 - Display error if group title is already used

Bug-15707---Display-error-if-group-title-is-alread.patch (text/plain), 2.30 KB, created by Jonathan Druart on 2017-12-05 17:00:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-12-05 17:00:27 UTC

Size: 2.30 KB

patch

obsolete

>From 78ff8a5201d3ecaf1a13789fe2af0d8b7d66c6d8 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 1 Mar 2017 13:58:54 +0000
>Subject: [PATCH] Bug 15707 - Display error if group title is already used
>
>---
> admin/library_groups.pl                            | 25 +++++++++++++---------
> .../prog/en/modules/admin/library_groups.tt        |  4 ++++
> 2 files changed, 19 insertions(+), 10 deletions(-)
>
>diff --git a/admin/library_groups.pl b/admin/library_groups.pl
>index e506d48789..0bd50b9b06 100755
>--- a/admin/library_groups.pl
>+++ b/admin/library_groups.pl
>@@ -48,16 +48,21 @@ if ( $action eq 'add' ) {
>     my $description = $cgi->param('description') || undef;
>     my $branchcode  = $cgi->param('branchcode')  || undef;
> 
>-    my $group = Koha::Library::Group->new(
>-        {
>-            parent_id   => $parent_id,
>-            title       => $title,
>-            description => $description,
>-            branchcode  => $branchcode,
>-        }
>-    )->store();
>-
>-    $template->param( added => $group );
>+    if ( Koha::Library::Groups->search( { title => $title } )->count() ) {
>+        $template->param( error_duplicate_title => $title );
>+    }
>+    else {
>+        my $group = Koha::Library::Group->new(
>+            {
>+                parent_id   => $parent_id,
>+                title       => $title,
>+                description => $description,
>+                branchcode  => $branchcode,
>+            }
>+        )->store();
>+
>+        $template->param( added => $group );
>+    }
> }
> elsif ( $action eq 'edit' ) {
>     my $id          = $cgi->param('id')          || undef;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
>index d3361072ae..95200b22ac 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
>@@ -108,6 +108,10 @@
>             [% deleted.library | $KohaSpan class = 'name' %] has been removed from group.
>         [% END %]
>     </div>
>+[% ELSIF error_duplicate_title %]
>+    <div class="dialog alert error-duplicate-group-title">
>+            A group with the title [% error_duplicate_title | $KohaSpan class = 'name' %] already exists.
>+    </div>
> [% END %]
> 
> <div id="doc3" class="yui-t2">
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 15707: 47479 | 47480 | 47481 | 47482 | 47483 | 47484 | 47728 | 47729 | 47730 | 47731 | 47732 | 47733 | 47734 | 47849 | 47850 | 47851 | 47852 | 47853 | 47854 | 47855 | 47868 | 47869 | 47870 | 47871 | 47872 | 47873 | 47874 | 48072 | 50400 | 50401 | 50402 | 50403 | 50404 | 50405 | 50406 | 50407 | 50408 | 52267 | 52268 | 52269 | 52270 | 52271 | 52272 | 52273 | 52274 | 52275 | 52367 | 52370 | 52562 | 52563 | 52564 | 52565 | 52566 | 52567 | 52568 | 52569 | 52570 | 52571 | 52572 | 52573 | 52574 | 52575 | 57080 | 57081 | 57082 | 57083 | 57084 | 57085 | 57086 | 57087 | 57088 | 57089 | 57090 | 57091 | 57092 | 57093 | 58086 | 60504 | 60505 | 60506 | 60507 | 60508 | 60509 | 60510 | 60511 | 60512 | 60513 | 60514 | 60515 | 60516 | 60517 | 60518 | 60572 | 60573 | 60574 | 60575 | 60576 | 60577 | 60578 | 60579 | 60580 | 60581 | 60582 | 60583 | 60584 | 60585 | 60586 | 60587 | 60755 | 60756 | 60757 | 60758 | 60759 | 60760 | 60761 | 60762 | 60763 | 60764 | 60765 | 60766 | 60767 | 60768 | 60769 | 60770 | 60771 | 65666 | 65667 | 65668 | 65669 | 65670 | 65671 | 65672 | 65673 | 65674 | 65675 | 65676 | 65677 | 65678 | 65679 | 65680 | 65681 | 69514 | 69515 | 69516 | 69517 | 69518 | 69519 | 69520 | 69521 | 69522 | 69523 | 69524 | 69525 | 69526 | 69527 | 69528 | 69529 | 69573 | 69574 | 69575 | 69576 | 69577 | 69578 | 69579 | 69580 | 69581 | 69582 | 69583 | 69584 | 69585 | 69586 | 69587 | 69588 | 69589