Bugzilla – Attachment 69550 Details for
Bug 16330
Add routes to add, update and delete patrons
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16330: (QA followup) Add missing POD for exceptions
Bug-16330-QA-followup-Add-missing-POD-for-exceptio.patch (text/plain), 4.69 KB, created by
Tomás Cohen Arazi (tcohen)
on 2017-12-05 19:45:53 UTC
(
hide
)
Description:
Bug 16330: (QA followup) Add missing POD for exceptions
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2017-12-05 19:45:53 UTC
Size:
4.69 KB
patch
obsolete
>From 9747f9b91bb56e596a04365ba225d5ee6581871a Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 5 Dec 2017 16:35:06 -0300 >Subject: [PATCH] Bug 16330: (QA followup) Add missing POD for exceptions > >This patch adds POD to the exceptions files introduced by this patchset. > >Note: the qa scripts give false positives on Exceptions. But the patchset >was missing them anyway. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Exceptions/Category.pm | 31 +++++++++++++++++++++++++++++++ > Koha/Exceptions/Library.pm | 31 +++++++++++++++++++++++++++++++ > Koha/Exceptions/Patron.pm | 31 +++++++++++++++++++++++++++++++ > 3 files changed, 93 insertions(+) > >diff --git a/Koha/Exceptions/Category.pm b/Koha/Exceptions/Category.pm >index 3487faa9c7..efd705f35d 100644 >--- a/Koha/Exceptions/Category.pm >+++ b/Koha/Exceptions/Category.pm >@@ -1,5 +1,20 @@ > package Koha::Exceptions::Category; > >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, write to the Free Software Foundation, Inc., >+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+ > use Modern::Perl; > > use Exception::Class ( >@@ -14,4 +29,20 @@ use Exception::Class ( > }, > ); > >+=head1 NAME >+ >+Koha::Exceptions::Category - Base class for patron categories exceptions >+ >+=head1 Exceptions >+ >+=head2 Koha::Exceptions::Category >+ >+Generic patron category exception >+ >+=head2 Koha::Exceptions::Category::CategorycodeNotFound >+ >+Exception to be used when the required patron category code is not found. >+ >+=cut >+ > 1; >diff --git a/Koha/Exceptions/Library.pm b/Koha/Exceptions/Library.pm >index 1aea6add13..a9d948ecf0 100644 >--- a/Koha/Exceptions/Library.pm >+++ b/Koha/Exceptions/Library.pm >@@ -1,5 +1,20 @@ > package Koha::Exceptions::Library; > >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, write to the Free Software Foundation, Inc., >+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+ > use Modern::Perl; > > use Exception::Class ( >@@ -14,4 +29,20 @@ use Exception::Class ( > }, > ); > >+=head1 NAME >+ >+Koha::Exceptions::Library - Base class for libraries exceptions >+ >+=head1 Exceptions >+ >+=head2 Koha::Exceptions::Library >+ >+Generic library exception >+ >+=head2 Koha::Exceptions::Library::BranchcodeNotFound >+ >+Exception to be used when the required library code is not found. >+ >+=cut >+ > 1; >diff --git a/Koha/Exceptions/Patron.pm b/Koha/Exceptions/Patron.pm >index c409b4e3d1..64430343fc 100644 >--- a/Koha/Exceptions/Patron.pm >+++ b/Koha/Exceptions/Patron.pm >@@ -1,5 +1,20 @@ > package Koha::Exceptions::Patron; > >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, write to the Free Software Foundation, Inc., >+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+ > use Modern::Perl; > > use Exception::Class ( >@@ -14,4 +29,20 @@ use Exception::Class ( > }, > ); > >+=head1 NAME >+ >+Koha::Exceptions::Patron - Base class for patrons exceptions >+ >+=head1 Exceptions >+ >+=head2 Koha::Exceptions::Patron >+ >+Generic patron exception >+ >+=head2 Koha::Exceptions::Patron::DuplicateObject >+ >+Exception to be used when trying to add duplicated data to the patrons DB. >+ >+=cut >+ > 1; >-- >2.14.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16330
:
50803
|
50889
|
51066
|
51131
|
51132
|
53216
|
53217
|
53820
|
54942
|
55147
|
56666
|
56667
|
56668
|
63646
|
63647
|
63649
|
63650
|
69546
|
69547
|
69548
|
69549
|
69550
|
69551
|
69752
|
69762
|
69763
|
69764
|
69765
|
69766
|
69767
|
69768
|
69787
|
70034
|
70035
|
70036
|
70037
|
70038
|
71667
|
71668
|
71669
|
71670
|
71671
|
71920
|
71921
|
71922
|
71923
|
71924
|
71925
|
71933
|
71934
|
71935
|
71936
|
71937
|
71938
|
73434