Attachment 69579 Details for Bug 15707 – Bug 15707: (QA followup) Drop table if exists

[patch] Bug 15707: (QA followup) Drop table if exists

Bug-15707-QA-followup-Drop-table-if-exists.patch (text/plain), 2.15 KB, created by Tomás Cohen Arazi (tcohen) on 2017-12-06 19:06:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-12-06 19:06:08 UTC

Size: 2.15 KB

patch

obsolete

>From 7a6ea4aadaf940286d032af2338c55d6618eeeee Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Sun, 12 Jun 2016 10:15:38 +0100
>Subject: [PATCH] Bug 15707: (QA followup) Drop table if exists
>
>1/ DROP table if exists
>2/ FAIL   spelling
>    decendents  ==> descendants
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> installer/data/mysql/kohastructure.sql | 1 +
> t/db_dependent/LibraryGroups.t         | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index f2aa6d1e05..f0b944db13 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -4179,6 +4179,7 @@ CREATE TABLE illrequestattributes (
> -- Table structure for table 'library_groups'
> --
> 
>+DROP TABLE IF EXISTS `library_groups`;
> CREATE TABLE library_groups (
>     id INT(11) NOT NULL auto_increment,    -- unique id for each group
>     parent_id INT(11) NULL DEFAULT NULL,   -- if this is a child group, the id of the parent group
>diff --git a/t/db_dependent/LibraryGroups.t b/t/db_dependent/LibraryGroups.t
>index 5076e11b15..c3aef9ff97 100644
>--- a/t/db_dependent/LibraryGroups.t
>+++ b/t/db_dependent/LibraryGroups.t
>@@ -74,6 +74,6 @@ is( $library->id, $groupA_library1->branchcode, 'Branchcode for fetched library
> 
> my @libraries_not_direct_children = $groupA->libraries_not_direct_children();
> $in_list = any { $_->id eq $groupA_library1->branchcode } @libraries_not_direct_children;
>-ok( !$in_list, 'Method libraries_not_direct_children returns all libraries not direct decendents of group, library 1 is not in the list');
>+ok( !$in_list, 'Method libraries_not_direct_children returns all libraries not direct descendants of group, library 1 is not in the list');
> $in_list = any { $_->id eq $groupA1_library2->branchcode } @libraries_not_direct_children;
>-ok( $in_list, 'Method libraries_not_direct_children returns all libraries not direct decendents of group, library 2 is in the list');
>+ok( $in_list, 'Method libraries_not_direct_children returns all libraries not direct descendants of group, library 2 is in the list');
>-- 
>2.14.1

Actions: View | Diff | Splinter Review

Attachments on bug 15707: 47479 | 47480 | 47481 | 47482 | 47483 | 47484 | 47728 | 47729 | 47730 | 47731 | 47732 | 47733 | 47734 | 47849 | 47850 | 47851 | 47852 | 47853 | 47854 | 47855 | 47868 | 47869 | 47870 | 47871 | 47872 | 47873 | 47874 | 48072 | 50400 | 50401 | 50402 | 50403 | 50404 | 50405 | 50406 | 50407 | 50408 | 52267 | 52268 | 52269 | 52270 | 52271 | 52272 | 52273 | 52274 | 52275 | 52367 | 52370 | 52562 | 52563 | 52564 | 52565 | 52566 | 52567 | 52568 | 52569 | 52570 | 52571 | 52572 | 52573 | 52574 | 52575 | 57080 | 57081 | 57082 | 57083 | 57084 | 57085 | 57086 | 57087 | 57088 | 57089 | 57090 | 57091 | 57092 | 57093 | 58086 | 60504 | 60505 | 60506 | 60507 | 60508 | 60509 | 60510 | 60511 | 60512 | 60513 | 60514 | 60515 | 60516 | 60517 | 60518 | 60572 | 60573 | 60574 | 60575 | 60576 | 60577 | 60578 | 60579 | 60580 | 60581 | 60582 | 60583 | 60584 | 60585 | 60586 | 60587 | 60755 | 60756 | 60757 | 60758 | 60759 | 60760 | 60761 | 60762 | 60763 | 60764 | 60765 | 60766 | 60767 | 60768 | 60769 | 60770 | 60771 | 65666 | 65667 | 65668 | 65669 | 65670 | 65671 | 65672 | 65673 | 65674 | 65675 | 65676 | 65677 | 65678 | 65679 | 65680 | 65681 | 69514 | 69515 | 69516 | 69517 | 69518 | 69519 | 69520 | 69521 | 69522 | 69523 | 69524 | 69525 | 69526 | 69527 | 69528 | 69529 | 69573 | 69574 | 69575 | 69576 | 69577 | 69578 | 69579 | 69580 | 69581 | 69582 | 69583 | 69584 | 69585 | 69586 | 69587 | 69588 | 69589