Attachment 69657 Details for Bug 19319 – Bug 19319: (QA follow-up) Biblionumber leftovers in opac-detail.tt

[patch] Bug 19319: (QA follow-up) Biblionumber leftovers in opac-detail.tt

Bug-19319-QA-follow-up-Biblionumber-leftovers-in-o.patch (text/plain), 5.85 KB, created by Jonathan Druart on 2017-12-08 18:03:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-12-08 18:03:54 UTC

Size: 5.85 KB

patch

obsolete

>From ab2940c30960bff251812330cc5ca1363d6c7c1d Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 8 Dec 2017 09:46:02 +0100
>Subject: [PATCH] Bug 19319: (QA follow-up) Biblionumber leftovers in
> opac-detail.tt
>
>Correcting a few biblionumber template var leftovers in opac-detail
>template. They were combined with url filter instead of html.
>
>Test plan:
>[1] Look for [^.;?]biblionumber in opac-detail.tt and verify that these
>    occurrences are fine.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index 61479d3ad5..74f8578f9e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -57,7 +57,7 @@
> 
>                     <div id="bookcover">
>                     [% IF ( OPACLocalCoverImages ) %]
>-                        <div title="[% biblionumber |url %]" class="[% biblio.biblionumber %]" id="local-thumbnail-preview"></div>
>+                        <div title="[% biblio.biblionumber %]" class="[% biblio.biblionumber %]" id="local-thumbnail-preview"></div>
>                     [% END %]
>                     [% IF ( OPACAmazonCoverImages ) %]
>                         [% IF ( OPACURLOpenInNewWindow ) %]
>@@ -82,14 +82,14 @@
>                     [% END %]
> 
>                     [% IF ( GoogleJackets ) %]
>-                        <div title="[% biblionumber |url %]" class="[% normalized_isbn %]" id="gbs-thumbnail-preview"></div>
>+                        <div title="[% biblio.biblionumber %]" class="[% normalized_isbn %]" id="gbs-thumbnail-preview"></div>
>                     [% END %]
>                     [% IF ( Koha.Preference('Coce') && Koha.Preference('CoceProviders') ) %]
>                       [% coce_id = normalized_ean || normalized_isbn %]
>-                      <div style="block" title="[% biblionumber |url %]" class="[% coce_id %]" id="coce-thumbnail-preview"></div>
>+                      <div style="block" title="[% biblio.biblionumber %]" class="[% coce_id %]" id="coce-thumbnail-preview"></div>
>                     [% END %]
>                     [% IF OpenLibraryCovers %]
>-                        <div title="[% biblionumber |url %]" class="[% normalized_isbn %]" id="openlibrary-thumbnail-preview"></div>
>+                        <div title="[% biblio.biblionumber %]" class="[% normalized_isbn %]" id="openlibrary-thumbnail-preview"></div>
>                     [% END %]
>                     [% bt_id = ( normalized_upc || normalized_isbn ) %]
>                     [% IF ( BakerTaylorEnabled && bt_id ) %]
>@@ -344,13 +344,13 @@
> 
>                                         [% IF ( OPACURLOpenInNewWindow ) %]
>                                             [% IF trackclicks == 'track' || trackclicks == 'anonymous' %]
>-                                                <a href="/cgi-bin/koha/tracklinks.pl?uri=[% MARCurl.MARCURL |url%]&amp;biblionumber=[% biblionumber | url %]" title="[% MARCurl.MARCURL %]" target="_blank" rel="noreferrer">
>+                                                <a href="/cgi-bin/koha/tracklinks.pl?uri=[% MARCurl.MARCURL |url%]&amp;biblionumber=[% biblio.biblionumber %]" title="[% MARCurl.MARCURL %]" target="_blank" rel="noreferrer">
>                                             [% ELSE %]
>                                                 <a href="[% MARCurl.MARCURL %]" title="[% MARCurl.MARCURL %]" target="_blank" rel="noreferrer">
>                                             [% END %]
>                                         [% ELSE %]
>                                             [% IF trackclicks == 'track' || trackclicks == 'anonymous' %]
>-                                                <a href="/cgi-bin/koha/tracklinks.pl?uri=[% MARCurl.MARCURL |url%]&amp;biblionumber=[% biblionumber | url %]" title="[% MARCurl.MARCURL %]">
>+                                                <a href="/cgi-bin/koha/tracklinks.pl?uri=[% MARCurl.MARCURL |url%]&amp;biblionumber=[% biblio.biblionumber %]" title="[% MARCurl.MARCURL %]">
>                                             [% ELSE %]
>                                                 <a href="[% MARCurl.MARCURL %]" title="[% MARCurl.MARCURL %]">
>                                             [% END %]
>@@ -1316,9 +1316,9 @@
>                             [% IF ITEM_RESULT.uri %]
>                                 [% IF trackclicks == 'track' || trackclicks == 'anonymous' %]
>                                     [% IF Koha.Preference("OPACURLOpenInNewWindow") %]
>-                                    <a target="_blank" rel="noreferrer" href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | uri %]&amp;biblionumber=[% biblionumber |url %]&amp;itemnumber=[% ITEM_RESULT.itemnumber | url %]" property="url"> Link to resource </a>
>+                                    <a target="_blank" rel="noreferrer" href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | uri %]&amp;biblionumber=[% biblio.biblionumber %]&amp;itemnumber=[% ITEM_RESULT.itemnumber | url %]" property="url"> Link to resource </a>
>                                     [% ELSE %]
>-                                    <a href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | uri %]&amp;biblionumber=[% biblionumber |url %]&amp;itemnumber=[% ITEM_RESULT.itemnumber | url %]" property="url"> Link to resource </a>
>+                                    <a href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | uri %]&amp;biblionumber=[% biblio.biblionumber %]&amp;itemnumber=[% ITEM_RESULT.itemnumber | url %]" property="url"> Link to resource </a>
>                                     [% END %]
> 
>                                 [% ELSE %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19319: 67140 | 68482 | 68486 | 69513 | 69634 | 69635 | 69656 | 69657 | 69658