Bugzilla – Attachment 69693 Details for
Bug 16735
Replace existing library search groups functionality with the new hierarchical groups system
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16735: (QA followup) POD fixes
Bug-16735-QA-followup-POD-fixes.patch (text/plain), 2.06 KB, created by
Tomás Cohen Arazi (tcohen)
on 2017-12-11 16:12:38 UTC
(
hide
)
Description:
Bug 16735: (QA followup) POD fixes
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2017-12-11 16:12:38 UTC
Size:
2.06 KB
patch
obsolete
>From 138124297338008502fadd944dd758008a3ac71c Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 11 Dec 2017 12:46:05 -0300 >Subject: [PATCH] Bug 16735: (QA followup) POD fixes > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Library/Group.pm | 8 +++++--- > installer/data/mysql/updatedatabase.pl | 3 +-- > 2 files changed, 6 insertions(+), 5 deletions(-) > >diff --git a/Koha/Library/Group.pm b/Koha/Library/Group.pm >index 5ac1360fb9..677ae1e6ad 100644 >--- a/Koha/Library/Group.pm >+++ b/Koha/Library/Group.pm >@@ -33,7 +33,7 @@ Koha::Library::Group - Koha Library::Group object class > > =head1 API > >-=head2 Class Methods >+=head2 Class methods > > =cut > >@@ -119,7 +119,7 @@ sub libraries { > > =head3 all_libraries > >-my @libraries = $group->libraries( { [invert => 1] } ); >+my @libraries = $group->all_libraries( { [invert => 1] } ); > > Returns the libraries set as children of this group or any subgroup. > >@@ -174,7 +174,9 @@ sub store { > return $self->SUPER::store(@_); > } > >-=head3 type >+=head2 Internal methods >+ >+=head3 _type > > =cut > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index bbb749d233..aef654ae55 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -15179,7 +15179,6 @@ if( CheckVersion( $DBversion ) ) { > > $DBversion = "XXX"; > if ( CheckVersion($DBversion) ) { >- require Koha::Library::Group; > > $dbh->do(q{ > INSERT INTO library_groups ( title, description, created_on ) VALUES ( '__SEARCH_GROUPS__', 'Library search groups - Staff only', NOW() ) >@@ -15223,7 +15222,7 @@ if ( CheckVersion($DBversion) ) { > # $dbh->do("DROP TABLE branchrelations"); > # $dbh->do("DROP TABLE branchcategories"); > >- print "Upgrade to $DBversion done (Bug 16735 - Replace existing library search groups functionality with the new hierarchical groups system)\n"; >+ print "Upgrade to $DBversion done (Bug 16735 - Migrate library search groups into the new hierarchical groups)\n"; > SetVersion($DBversion); > } > >-- >2.14.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16735
:
52732
|
52733
|
52734
|
52735
|
57098
|
57099
|
57100
|
57101
|
58087
|
58088
|
58089
|
58090
|
60497
|
60498
|
60499
|
60500
|
60501
|
60502
|
60503
|
60772
|
60773
|
60774
|
60775
|
60776
|
60777
|
60778
|
60779
|
65658
|
65659
|
65660
|
65661
|
65662
|
65663
|
65664
|
65665
|
69533
|
69534
|
69535
|
69536
|
69537
|
69538
|
69539
|
69540
|
69541
|
69684
|
69685
|
69686
|
69687
|
69688
|
69689
|
69690
|
69691
|
69692
| 69693 |
69694
|
71386
|
71393