Attachment 697 Details for Bug 2505 – Patch for members/messaging.pl and members/readingrec.pl

[patch] Patch for members/messaging.pl and members/readingrec.pl

0010-Bug-2505-Enabled-warnings-in-members-messaging.pl-a.patch (text/plain), 1.52 KB, created by Chris Cormack on 2009-09-21 23:24:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2009-09-21 23:24:00 UTC

Size: 1.52 KB

patch

obsolete

>From 5d6529903c2a77ffc420ed304cef03e1c98e6553 Mon Sep 17 00:00:00 2001
>From: Garry Collum <gcollum@gmail.com>
>Date: Mon, 21 Sep 2009 19:25:19 -0400
>Subject: [PATCH] Bug 2505: Enabled warnings in members/messaging.pl and readingrec.pl.
>Content-Type: text/plain; charset="utf-8"
>
>Fixed any warnings that appeared in the logs.
>---
> members/messaging.pl  |    4 +++-
> members/readingrec.pl |    4 +++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/members/messaging.pl b/members/messaging.pl
>index 1427973..7ae18e9 100755
>--- a/members/messaging.pl
>+++ b/members/messaging.pl
>@@ -19,6 +19,8 @@
> 
> 
> use strict;
>+use warnings;
>+
> use CGI;
> use C4::Context;
> use C4::Auth;
>@@ -62,7 +64,7 @@ my $branch         = C4::Context->userenv->{'branch'};
> 
> $template->param( $borrower );
> 
>-my $borrower = GetMemberDetails( $borrowernumber );
>+$borrower = GetMemberDetails( $borrowernumber );
> 
> 
>     if ( $borrower->{'category_type'} eq 'C') {
>diff --git a/members/readingrec.pl b/members/readingrec.pl
>index 7ffdfee..ce3fb37 100755
>--- a/members/readingrec.pl
>+++ b/members/readingrec.pl
>@@ -21,6 +21,8 @@
> # Suite 330, Boston, MA  02111-1307 USA
> 
> use strict;
>+use warnings;
>+
> use C4::Auth;
> use C4::Output;
> use CGI;
>@@ -34,7 +36,7 @@ my $input=new CGI;
> my $borrowernumber=$input->param('borrowernumber');
> #get borrower details
> my $data=GetMember($borrowernumber,'borrowernumber');
>-my $order=$input->param('order');
>+my $order=$input->param('order') || '';
> my $order2=$order;
> if ($order2 eq ''){
>   $order2="date_due desc";
>-- 
>1.5.6.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 2505: 686 | 687 | 688 | 689 | 690 | 691 | 692 | 693 | 694 | 695 | 696 | 697 | 698 | 699 | 700 | 701 | 702 | 703 | 704 | 705 | 706 | 707 | 708 | 709 | 2223 | 3884 | 4574 | 8209 | 8317 | 8322 | 8373 | 9034 | 9035 | 9036 | 34442