Attachment 69856 Details for Bug 19808 – Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl

[patch] Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl

Bug-19808-Handle-deleted-reviewers-gracefully---re.patch (text/plain), 1.65 KB, created by Jonathan Druart on 2017-12-18 16:36:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-12-18 16:36:57 UTC

Size: 1.65 KB

patch

obsolete

>From 2715b6e3be942b43f905b2033a2077968988e86e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 18 Dec 2017 13:32:19 -0300
>Subject: [PATCH] Bug 19808: Handle deleted reviewers gracefully -
> reviews/reviewswaiting.pl
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Test plan:
>- Create reviews
>- Delete some reviewers
>- Go to Home âº Tools âº Comments âº Comments awaiting moderation
>---
> reviews/reviewswaiting.pl | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
>diff --git a/reviews/reviewswaiting.pl b/reviews/reviewswaiting.pl
>index 528425290d..82b1234807 100755
>--- a/reviews/reviewswaiting.pl
>+++ b/reviews/reviewswaiting.pl
>@@ -67,14 +67,17 @@ my $reviews = Koha::Reviews->search(
>     }
> )->unblessed;
> 
>-foreach ( @$reviews ) {
>-    my $borrowernumber = $_->{borrowernumber};
>-    my $patron = Koha::Patrons->find( $borrowernumber);
>-    my $biblio         = Koha::Biblios->find( $_->{biblionumber} );
>+for my $review ( @$reviews ) {
>+    my $biblio         = Koha::Biblios->find( $review->{biblionumber} );
>     # setting some borrower info into this hash
>-    $_->{bibliotitle} = $biblio->title;
>-    $_->{surname}     = $patron->surname;
>-    $_->{firstname}   = $patron->firstname;
>+    $review->{bibliotitle} = $biblio->title;
>+
>+    my $borrowernumber = $review->{borrowernumber};
>+    my $patron = Koha::Patrons->find( $borrowernumber);
>+    if ( $patron ) {
>+        $review->{surname}     = $patron->surname;
>+        $review->{firstname}   = $patron->firstname;
>+    }
> }
> 
> my $url = "/cgi-bin/koha/reviews/reviewswaiting.pl?status=$status";
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19808: 69824 | 69828 | 69853 | 69854 | 69855 | 69856 | 69926 | 69934 | 69935 | 69936 | 69937 | 69938 | 69989 | 69990 | 69991 | 69992 | 69993