Bugzilla – Attachment 69983 Details for
Bug 19756
Encoding issues when update DB is run from the interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19756: Fix encoding issues during the update DB process
Bug-19756-Fix-encoding-issues-during-the-update-DB.patch (text/plain), 1.80 KB, created by
Liz Rea
on 2017-12-21 00:14:43 UTC
(
hide
)
Description:
Bug 19756: Fix encoding issues during the update DB process
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2017-12-21 00:14:43 UTC
Size:
1.80 KB
patch
obsolete
>From c20daa1ad40c33d4b372a4e1e2d38dd708204902 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 20 Dec 2017 18:59:39 -0300 >Subject: [PATCH] Bug 19756: Fix encoding issues during the update DB process >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To display the output of the updatedatabase.pl under Plack, we redirect >the output to a temporary file, read it, then display it. >We need to open it specifying the correct encoding (utf-8). > >Test plan: >1. MariaDB [koha_kohadev]> update systempreferences set value="17.1100000" >where variable="version"; >2. restart plack >3. Login >4. Make the update from the interface >=> Without this patch you will see encoding issue: >Upgrade to 17.12.00.000 done (TÃÂ tÃÂia, tÃÂ haumatia) >=> With this patch applied you will see : >Upgrade to 17.12.00.000 done (TÄ tÅia, tÄ haumatia) > >Signed-off-by: Liz Rea <liz@catalyst.net.nz> >--- > installer/install.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/installer/install.pl b/installer/install.pl >index ac43214..bf0b9d1 100755 >--- a/installer/install.pl >+++ b/installer/install.pl >@@ -394,7 +394,7 @@ elsif ( $step && $step == 3 ) { > system($cmd ); > > my $fh; >- open( $fh, "<", $logfilepath ) >+ open( $fh, "<:encoding(utf-8)", $logfilepath ) > or die "Cannot open log file $logfilepath: $!"; > my @report = <$fh>; > close $fh; >@@ -407,7 +407,7 @@ elsif ( $step && $step == 3 ) { > else { > eval { `rm $logfilepath` }; > } >- open( $fh, "<", $logfilepath_errors ) >+ open( $fh, "<:encoding(utf-8)", $logfilepath_errors ) > or die "Cannot open log file $logfilepath_errors: $!"; > @report = <$fh>; > close $fh; >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19756
:
69552
|
69980
|
69983
|
70040