Attachment 69990 Details for Bug 19808 – Bug 19808: (follow-up) Handle deleted reviewers gracefully - opac-detail

[patch] Bug 19808: (follow-up) Handle deleted reviewers gracefully - opac-detail

Bug-19808-follow-up-Handle-deleted-reviewers-grace.patch (text/plain), 1.53 KB, created by Kyle M Hall (khall) on 2017-12-21 10:46:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2017-12-21 10:46:14 UTC

Size: 1.53 KB

patch

obsolete

>From a9ef1f8e085fd89cd4eecebc0bd9654dcc3b824a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 18 Dec 2017 13:32:02 -0300
>Subject: [PATCH] Bug 19808: (follow-up) Handle deleted reviewers gracefully -
> opac-detail
>
>Make the tests easier to read
>
>Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> opac/opac-detail.pl | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
>diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
>index 745c49c..9ace469 100755
>--- a/opac/opac-detail.pl
>+++ b/opac/opac-detail.pl
>@@ -844,13 +844,15 @@ if ( C4::Context->preference('reviewson') ) {
>         my $patron = Koha::Patrons->find( $review->{borrowernumber} );
> 
>         # setting some borrower info into this hash
>-        $review->{patron} = $patron;
>-        if ( $libravatar_enabled and $patron and $patron->email ) {
>-            $review->{avatarurl} = libravatar_url( email => $patron->email, https => $ENV{HTTPS} );
>-        }
>+        if ( $patron ) {
>+            $review->{patron} = $patron;
>+            if ( $libravatar_enabled and $patron->email ) {
>+                $review->{avatarurl} = libravatar_url( email => $patron->email, https => $ENV{HTTPS} );
>+            }
> 
>-        if ( $patron and $patron->borrowernumber eq $borrowernumber ) {
>-            $loggedincommenter = 1;
>+            if ( $patron->borrowernumber eq $borrowernumber ) {
>+                $loggedincommenter = 1;
>+            }
>         }
>     }
> }
>-- 
>2.10.2

Actions: View | Diff | Splinter Review

Attachments on bug 19808: 69824 | 69828 | 69853 | 69854 | 69855 | 69856 | 69926 | 69934 | 69935 | 69936 | 69937 | 69938 | 69989 | 69990 | 69991 | 69992 | 69993