Bugzilla – Attachment 69993 Details for
Bug 19808
Reviews from deleted patrons make few scripts to explode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19808: Do not display 'Added' alone
Bug-19808-Do-not-display-Added-alone.patch (text/plain), 2.13 KB, created by
Kyle M Hall (khall)
on 2017-12-21 10:46:22 UTC
(
hide
)
Description:
Bug 19808: Do not display 'Added' alone
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2017-12-21 10:46:22 UTC
Size:
2.13 KB
patch
obsolete
>From f86e616877b21c18c58bc031cab6643b8594da09 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 19 Dec 2017 16:28:00 -0300 >Subject: [PATCH] Bug 19808: Do not display 'Added' alone > >It seems that reviews.datereviewed ends with NULL in DB. >It is caused by another issue that will be fixed on another bug report. > >Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt >index 507c118..fceb84f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt >@@ -86,8 +86,12 @@ > [% FILTER html_break %] > [% review.review |html %] > [% END %] >- <span style="font-size:87%;font-color:#CCC;">Added [% review.datereviewed | $KohaDates %] [% IF ( review.your_comment ) %] by <strong>you</strong>[% ELSE %] >- [% IF ( review.borrowernumber && ShowReviewer != "none" ) %] by >+ <span style="font-size:87%;font-color:#CCC;"> >+ [% IF review.your_comment %] >+ Added [% review.datereviewed | $KohaDates %] by you >+ [% ELSE %] >+ [% IF ( review.borrowernumber && ShowReviewer != "none" ) %] >+ Added [% review.datereviewed | $KohaDates %] by > [% SWITCH ShowReviewer %] > [% CASE 'full' %] > [% review.borrtitle %] [% review.firstname %] [% review.surname %] >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19808
:
69824
|
69828
|
69853
|
69854
|
69855
|
69856
|
69926
|
69934
|
69935
|
69936
|
69937
|
69938
|
69989
|
69990
|
69991
|
69992
| 69993