Bugzilla – Attachment 69996 Details for
Bug 15752
Automatically switch from circulation to new patron when a cardnumber is scanned during circulation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15752: QA followup - inform user that patron was automatically switched
Bug-15752-QA-followup---inform-user-that-patron-wa.patch (text/plain), 2.63 KB, created by
Kyle M Hall (khall)
on 2017-12-21 10:54:32 UTC
(
hide
)
Description:
Bug 15752: QA followup - inform user that patron was automatically switched
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2017-12-21 10:54:32 UTC
Size:
2.63 KB
patch
obsolete
>From 669a96714f1b45577b67ae9531b2e47dfad297c4 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Fri, 18 Aug 2017 10:58:51 +0000 >Subject: [PATCH] Bug 15752: QA followup - inform user that patron was > automatically switched > >Test plan: > >1) Start checking out to some patron - there should be no message about >auto switching >2) read the another patrons card - note the patron is switched and there >is a message about it at top of the main page content > >Followed test plan, patch worked as described. Passed QA test tool >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > circ/circulation.pl | 3 ++- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 4 ++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index 73ca23e..45b8f5b 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -87,7 +87,7 @@ my $barcode = $query->param('barcode'); > > if (C4::Context->preference("AutoSwitchPatron") && $barcode) { > if (Koha::Patrons->search( { cardnumber => $barcode} )->count() > 0) { >- print $query->redirect("/cgi-bin/koha/circ/circulation.pl?findborrower=".$barcode); >+ print $query->redirect("/cgi-bin/koha/circ/circulation.pl?findborrower=$barcode&autoswitched=1"); > } > } > >@@ -665,6 +665,7 @@ $template->param( > has_modifications => $has_modifications, > override_high_holds => $override_high_holds, > nopermission => scalar $query->param('nopermission'), >+ autoswitched => $query->param("autoswitched"), > ); > > output_html_with_http_headers $query, $cookie, $template->output; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 842e479..1226751 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -159,6 +159,10 @@ $(document).ready(function() { > <!-- INITIAL BLOC : PARAMETERS & BORROWER INFO --> > [% IF ( was_renewed ) %]<div class="dialog message">Patron's account has been renewed until [% expiry | $KohaDates %]</div>[% END %] > >+[% IF autoswitched %] >+ <div id="autoswitched" class="dialog message">Patron was automatically switched by reading the patron card during checking out. Ensure you are working with the right patron.</div> >+[% END %] >+ > [% IF additional_materials %] > <div id="materials" class="dialog message">Note about the accompanying materials: <br /> > [% additional_materials %] >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15752
:
47716
|
55953
|
57015
|
66175
|
66176
|
66177
|
67037
|
67038
|
67039
|
67174
|
67175
|
67176
|
69994
|
69995
|
69996
|
70077
|
70085
|
71359
|
71360
|
71361
|
71362
|
71363