Attachment 70001 Details for Bug 19694 – Bug 19694: Force scalar context for output_pref called with billingdate

[patch] Bug 19694: Force scalar context for output_pref called with billingdate

Bug-19694-Force-scalar-context-for-outputpref-call.patch (text/plain), 1.67 KB, created by Kyle M Hall (khall) on 2017-12-21 11:38:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2017-12-21 11:38:00 UTC

Size: 1.67 KB

patch

obsolete

>From e0d56e492edbcd5bc8ae5517921c32bdb1c27f31 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 19 Dec 2017 15:04:13 -0300
>Subject: [PATCH] Bug 19694: Force scalar context for output_pref called with
> billingdate
>
>If no string is passed to output_pref, it needs to be called in scalar
>context (to avoid a shift in the hash elements).
>Here we have billingdate that is not defined yet (NULL)
>
>Test plan:
>- Search for an existing invoice
>- Show details
>- Changing shipping cost
>- Save
>- Verify the new amount is shown
>
>Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> acqui/invoice.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/acqui/invoice.pl b/acqui/invoice.pl
>index 3ab2d9f..dd1360f 100755
>--- a/acqui/invoice.pl
>+++ b/acqui/invoice.pl
>@@ -84,8 +84,8 @@ elsif ( $op && $op eq 'mod' ) {
>     ModInvoice(
>         invoiceid             => $invoiceid,
>         invoicenumber         => $invoicenumber,
>-        shipmentdate          => output_pref( { str => scalar $input->param('shipmentdate'), dateformat => 'iso', dateonly => 1 } ),
>-        billingdate           => output_pref( { str => scalar $input->param('billingdate'),  dateformat => 'iso', dateonly => 1 } ),
>+        shipmentdate          => scalar output_pref( { str => scalar $input->param('shipmentdate'), dateformat => 'iso', dateonly => 1 } ),
>+        billingdate           => scalar output_pref( { str => scalar $input->param('billingdate'),  dateformat => 'iso', dateonly => 1 } ),
>         shipmentcost          => $shipmentcost,
>         shipmentcost_budgetid => $shipment_budget_id
>     );
>-- 
>2.10.2

Actions: View | Diff | Splinter Review

Attachments on bug 19694: 69922 | 69962 | 70001