Attachment 70024 Details for Bug 19429 – Bug 19429: Adding confirm message when deleting invoice from invoice search page

[patch] Bug 19429: Adding confirm message when deleting invoice from invoice search page

Bug-19429-Adding-confirm-message-when-deleting-inv.patch (text/plain), 3.64 KB, created by Kyle M Hall (khall) on 2017-12-21 13:56:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2017-12-21 13:56:15 UTC

Size: 3.64 KB

patch

obsolete

>From 6476f7949490aa7624573548c6156e15bf3938a8 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Tue, 10 Oct 2017 02:17:36 +0000
>Subject: [PATCH] Bug 19429: Adding confirm message when deleting invoice from
> invoice search page
>
>To test:
>To test:
>1) Go to Acquisitions
>2) Go to Invoices (left nav menu)
>3) Click Search (no need to filter results)
>4) Click dropdown menu for an invoice, click Delete
>5) Notice invoice is deleted instantly
>6) Apply patch and repeat steps 3 and 4
>7) Confirm the confirm message shows and works as expected
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
>index de03894..083f5cb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
>@@ -10,6 +10,10 @@
> <script type="text/javascript">
> //<![CDATA[
> $(document).ready(function() {
>+    $(".delete").click(function(){
>+        return confirmDelete(_("Are you sure you want to delete this invoice?"));
>+    });
>+
>     var resultst = $("#resultst").dataTable($.extend(true, {}, dataTablesDefaults, {
>         bPaginate: false,
>         aoColumnDefs: [
>@@ -159,7 +163,7 @@ $(document).ready(function() {
>                                 <li><a href="invoice.pl?op=close&amp;invoiceid=[% invoice.invoiceid %]&amp;referer=/cgi-bin/koha/acqui/invoices.pl%3Fop=do_search%26invoicenumber=[% invoicenumber %]%26supplier=[% booksellerid %]%26shipmentdatefrom=[% shipmentdatefrom | $KohaDates %]%26shipmentdateto=[% shipmentdateto | $KohaDates %]%26billingdatefrom=[% billingdatefrom | $KohaDates %]%26billingdateto=[% billingdateto | $KohaDates %]%26isbneanissn=[% isbneanissn %]%26title=[% title %]%26author=[% author %]%26publisher=[% publisher %]%26publicationyear=[% publicationyear %]%26branch=[% branch %]"><i class="fa fa-times-circle"></i> Close</a></li>
>                             [% END %]
>                             [% UNLESS invoice.receivedbiblios || invoice.receiveditems %]
>-                                <li><a href="invoice.pl?op=delete&amp;invoiceid=[% invoice.invoiceid %]&amp;referer=/cgi-bin/koha/acqui/invoices.pl%3Fop=do_search%26invoicenumber=[% invoicenumber %]%26supplier=[% booksellerid %]%26shipmentdatefrom=[% shipmentdatefrom | $KohaDates %]%26shipmentdateto=[% shipmentdateto | $KohaDates %]%26billingdatefrom=[% billingdatefrom | $KohaDates %]%26billingdateto=[% billingdateto | $KohaDates %]%26isbneanissn=[% isbneanissn %]%26title=[% title %]%26author=[% author %]%26publisher=[% publisher %]%26publicationyear=[% publicationyear %]%26branch=[% branch %]"><i class="fa fa-trash"></i> Delete</a></li>
>+                                <li><a href="invoice.pl?op=delete&amp;invoiceid=[% invoice.invoiceid %]&amp;referer=/cgi-bin/koha/acqui/invoices.pl%3Fop=do_search%26invoicenumber=[% invoicenumber %]%26supplier=[% booksellerid %]%26shipmentdatefrom=[% shipmentdatefrom | $KohaDates %]%26shipmentdateto=[% shipmentdateto | $KohaDates %]%26billingdatefrom=[% billingdatefrom | $KohaDates %]%26billingdateto=[% billingdateto | $KohaDates %]%26isbneanissn=[% isbneanissn %]%26title=[% title %]%26author=[% author %]%26publisher=[% publisher %]%26publicationyear=[% publicationyear %]%26branch=[% branch %]" class="delete"><i class="fa fa-trash"></i> Delete</a></li>
>                             [% END %]
>                           </ul>
>                       </div>
>-- 
>2.10.2

Actions: View | Diff | Splinter Review

Attachments on bug 19429: 67861 | 67968 | 70024 | 70057