Attachment 70028 Details for Bug 19315 – Bug 19315: [16.11.x] Prevent crash if no items and not library set for the subscription

[patch] Bug 19315: [16.11.x] Prevent crash if no items and not library set for the subscription

Bug-19315-1611x-Prevent-crash-if-no-items-and-not-.patch (text/plain), 1.79 KB, created by Jonathan Druart on 2017-12-21 14:03:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-12-21 14:03:26 UTC

Size: 1.79 KB

patch

obsolete

>From 665f7fe5b91a87789d6970d25d1c51a22f635fc5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 21 Dec 2017 10:49:41 -0300
>Subject: [PATCH] Bug 19315: [16.11.x] Prevent crash if no items and not
> library set for the subscription
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> serials/routing-preview.pl | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/serials/routing-preview.pl b/serials/routing-preview.pl
>index 2ad7cdb0bc..fec8ff5ce1 100755
>--- a/serials/routing-preview.pl
>+++ b/serials/routing-preview.pl
>@@ -60,13 +60,14 @@ my $subs = GetSubscription($subscriptionid);
> my ($tmp ,@serials) = GetSerials($subscriptionid);
> my ($template, $loggedinuser, $cookie);
> 
>+my $library;
> if($ok){
>     # get biblio information....
>     my $biblionumber = $subs->{'bibnum'};
>     my ($count2,@bibitems) = GetBiblioItemByBiblioNumber($biblionumber);
>     my @itemresults = GetItemsInfo( $biblionumber );
>     my $branch = @itemresults ? $itemresults[0]->{'holdingbranch'} : $subs->{branchcode};
>-    my $branchname = Koha::Libraries->find($branch)->branchname;
>+    $library = Koha::Libraries->find($branch);
> 
> 	if (C4::Context->preference('RoutingListAddReserves')){
> 		# get existing reserves .....
>@@ -106,7 +107,6 @@ if($ok){
> 				flagsrequired => {serials => '*'},
> 				debug => 1,
> 				});
>-    $template->param("libraryname"=>$branchname);
> } else {
>     ($template, $loggedinuser, $cookie)
> = get_template_and_user({template_name => "serials/routing-preview.tt",
>@@ -118,6 +118,8 @@ if($ok){
> 				});
> }
> 
>+$template->param( libraryname => $library->branchname ) if $library;
>+
> my $memberloop = [];
> for my $routing (@routinglist) {
>     my $member = GetMember( borrowernumber => $routing->{borrowernumber} );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19315: 67134 | 67164 | 67668 | 67669 | 70022 | 70026 | 70027 | 70028 | 70044 | 70045 | 70046