Bugzilla – Attachment 70045 Details for
Bug 19315
Routing preview may use wrong biblionumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 19315: [16.11.x] [QA Follow-up] Trivial edits
SIGNED-OFF-Bug-19315-1611x-QA-Follow-up-Trivial-ed.patch (text/plain), 1.21 KB, created by
Katrin Fischer
on 2017-12-21 15:06:51 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 19315: [16.11.x] [QA Follow-up] Trivial edits
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-12-21 15:06:51 UTC
Size:
1.21 KB
patch
obsolete
>From a44f4a42a202019a5c18cfc05c1ec0424e7d713c Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 6 Oct 2017 08:21:23 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 19315: [16.11.x] [QA Follow-up] Trivial > edits > >Replace $subs->{bibnum} by $biblionumber on a following line. >The scalar in the boolean expression is not needed. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > serials/routing-preview.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/serials/routing-preview.pl b/serials/routing-preview.pl >index 64c7752..2ad7cdb 100755 >--- a/serials/routing-preview.pl >+++ b/serials/routing-preview.pl >@@ -65,7 +65,7 @@ if($ok){ > my $biblionumber = $subs->{'bibnum'}; > my ($count2,@bibitems) = GetBiblioItemByBiblioNumber($biblionumber); > my @itemresults = GetItemsInfo( $biblionumber ); >- my $branch = scalar @itemresults ? $itemresults[0]->{'holdingbranch'} : $subs->{branchcode}; >+ my $branch = @itemresults ? $itemresults[0]->{'holdingbranch'} : $subs->{branchcode}; > my $branchname = Koha::Libraries->find($branch)->branchname; > > if (C4::Context->preference('RoutingListAddReserves')){ >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19315
:
67134
|
67164
|
67668
|
67669
|
70022
|
70026
|
70027
|
70028
|
70044
| 70045 |
70046