Attachment 70076 Details for Bug 19867 – Bug 19867: Prevent HouseboundRoles.t to fail randomly

[patch] Bug 19867: Prevent HouseboundRoles.t to fail randomly

Bug-19867-Prevent-HouseboundRolest-to-fail-randoml.patch (text/plain), 1.45 KB, created by Tomás Cohen Arazi (tcohen) on 2017-12-21 18:08:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-12-21 18:08:32 UTC

Size: 1.45 KB

patch

obsolete

>From a45d9b966af03b0526c4db2da0e79201b8bb8fae Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 21 Dec 2017 14:45:51 -0300
>Subject: [PATCH] Bug 19867: Prevent HouseboundRoles.t to fail randomly
>
>Here is just a guess but we need to tell TestBuilder the values of
>housebound_deliverer and housebound_chooser to make sure it will not be
>1
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>I manually tested setting to the opposite values in the tests, and
>verified those values made the tests fail due to count problems.
>The fix is valid.
>---
> t/db_dependent/Patron/HouseboundRoles.t | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Patron/HouseboundRoles.t b/t/db_dependent/Patron/HouseboundRoles.t
>index 090ca63e01..7ed46b7dc5 100644
>--- a/t/db_dependent/Patron/HouseboundRoles.t
>+++ b/t/db_dependent/Patron/HouseboundRoles.t
>@@ -62,7 +62,8 @@ $builder->build({
>     source => 'HouseboundRole',
>     value  => {
>         borrowernumber_id  => $patron_chooser->{borrowernumber},
>-        housebound_chooser => 1,
>+        housebound_chooser   => 1,
>+        housebound_deliverer => 0,
>     },
> });
> 
>@@ -72,6 +73,7 @@ $builder->build({
>     value  => {
>         borrowernumber_id    => $patron_deliverer->{borrowernumber},
>         housebound_deliverer => 1,
>+        housebound_chooser   => 0,
>     },
> });
> 
>-- 
>2.15.1

Actions: View | Diff | Splinter Review

Attachments on bug 19867: 70072 | 70076