Bugzilla – Attachment 70083 Details for
Bug 19702
Basket not displaying correctly on home page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19702: Correct cookie path in Basket.js
Bug-19702-Correct-cookie-path-in-Basketjs.patch (text/plain), 1.59 KB, created by
Josef Moravec
on 2017-12-21 20:07:35 UTC
(
hide
)
Description:
Bug 19702: Correct cookie path in Basket.js
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2017-12-21 20:07:35 UTC
Size:
1.59 KB
patch
obsolete
>From 4ce4ecf3948985b668c9458526d4e5c2569c2c2c Mon Sep 17 00:00:00 2001 >From: David Bourgault <david.bourgault@inlibro.com> >Date: Mon, 27 Nov 2017 16:05:48 -0500 >Subject: [PATCH] Bug 19702: Correct cookie path in Basket.js >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This corrects the cookie path in bootstrap/js/basket.js. It used to take >the default value (current page path), but will now be "/" > >Test plan: >0) Visit the OPAC, add a book to your basket >1) Navigate to the OPAC's homepage (www.domain.com, without the > /cgi-bin/koha) > -> The basket will display as empty > 2) Apply patch > 3) Clear your cookies and your cache > 4) Redo step 1) > -> Basket will display correctly > >Patch applies without issue and functions as descibed. >Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/basket.js b/koha-tmpl/opac-tmpl/bootstrap/js/basket.js >index a422753..ac5b1cd 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/basket.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/basket.js >@@ -19,10 +19,10 @@ function basketCount(){ > > function writeCookie(name, val, wd) { > if (wd) { >- parent.opener.document.cookie = name + "=" + val; >+ parent.opener.document.cookie = name + "=" + val + ";path=/"; > } > else { >- parent.document.cookie = name + "=" + val; >+ parent.document.cookie = name + "=" + val + ";path=/"; > } > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19702
:
69402
|
69407
| 70083