Bugzilla – Attachment 70100 Details for
Bug 19828
Koha::Object->store should catch DBIC exceptions and raise Koha::Exceptions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19828: (QA follow-up) Fix rethrowing exception and move rethrowing out of 'if' statement just in case the exception does not came from DBIx::Class
Bug-19828-QA-follow-up-Fix-rethrowing-exception-an.patch (text/plain), 940 bytes, created by
Josef Moravec
on 2017-12-22 07:46:43 UTC
(
hide
)
Description:
Bug 19828: (QA follow-up) Fix rethrowing exception and move rethrowing out of 'if' statement just in case the exception does not came from DBIx::Class
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2017-12-22 07:46:43 UTC
Size:
940 bytes
patch
obsolete
>From 48dec364f0204ad01a09844e8ef25ecd573285fa Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Fri, 22 Dec 2017 07:43:39 +0000 >Subject: [PATCH] Bug 19828: (QA follow-up) Fix rethrowing exception and move > rethrowing out of 'if' statement just in case the exception does not came > from DBIx::Class > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > Koha/Object.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Object.pm b/Koha/Object.pm >index 17609f2..7f36a7d 100644 >--- a/Koha/Object.pm >+++ b/Koha/Object.pm >@@ -142,9 +142,9 @@ sub store { > duplicate_id => $+{key} > ); > } >- # Catch-all for foreign key breakages. It will help find other use cases >- $->rethrow(); > } >+ # Catch-all for foreign key breakages. It will help find other use cases >+ $_->rethrow(); > } > } > >-- >2.1.4
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=70100">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19828
:
69857
|
69858
|
69907
|
69908
|
69963
|
69964
|
69965
|
70048
|
70049
|
70050
|
70097
|
70098
|
70099
| 70100