Bugzilla – Attachment 70114 Details for
Bug 19200
Warns when exporting a basket
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19200: (QA follow-up) Simplify call to GetBasketAsCSV
Bug-19200-QA-follow-up-Simplify-call-to-GetBasketA.patch (text/plain), 1.29 KB, created by
Marcel de Rooy
on 2017-12-22 10:26:12 UTC
(
hide
)
Description:
Bug 19200: (QA follow-up) Simplify call to GetBasketAsCSV
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-12-22 10:26:12 UTC
Size:
1.29 KB
patch
obsolete
>From 046f75ad0c3d36d6660f0d08af29b8ee87ca8e30 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 22 Dec 2017 11:20:13 +0100 >Subject: [PATCH] Bug 19200: (QA follow-up) Simplify call to GetBasketAsCSV >Content-Type: text/plain; charset=utf-8 > >If no profile_id is passed, GetBasketAsCSV will fallback to default itself. >No need to make the distinction in basket.pl. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > acqui/basket.pl | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > >diff --git a/acqui/basket.pl b/acqui/basket.pl >index 8df5f8b..92fae60 100755 >--- a/acqui/basket.pl >+++ b/acqui/basket.pl >@@ -171,13 +171,7 @@ if ( $op eq 'delete_confirm' ) { > -attachment => 'basket' . $basket->{'basketno'} . '.csv', > ); > my $csv_profile_id = $query->param('csv_profile'); >- if (defined $csv_profile_id) { >- # using a csv profile >- print GetBasketAsCSV(scalar $query->param('basketno'), $query, $csv_profile_id); >- } else { >- # using default >- print GetBasketAsCSV(scalar $query->param('basketno'), $query); >- } >+ print GetBasketAsCSV( scalar $query->param('basketno'), $query, $csv_profile_id ); # if no csv_profile_id passed, using default rows > exit; > } elsif ($op eq 'email') { > my $err = eval { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19200
:
66602
|
67799
|
69959
|
70113
| 70114