Bugzilla – Attachment 70187 Details for
Bug 18736
Problems in order calculations (rounding errors)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18736 - Add OrerPriceRounding syspref
Bug-18736---Add-OrerPriceRounding-syspref.patch (text/plain), 3.14 KB, created by
Nick Clemens (kidclamp)
on 2017-12-28 16:40:35 UTC
(
hide
)
Description:
Bug 18736 - Add OrerPriceRounding syspref
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-12-28 16:40:35 UTC
Size:
3.14 KB
patch
obsolete
>From 392ab22149f0c9cf496ce0b42de7b3384c7c677c Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 28 Dec 2017 15:11:11 +0000 >Subject: [PATCH] Bug 18736 - Add OrerPriceRounding syspref > >--- > .../data/mysql/atomicupdate/bug18736_add_rounding_syspref.perl | 7 +++++++ > installer/data/mysql/sysprefs.sql | 1 + > .../prog/en/modules/admin/preferences/acquisitions.pref | 7 +++++++ > 3 files changed, 15 insertions(+) > create mode 100644 installer/data/mysql/atomicupdate/bug18736_add_rounding_syspref.perl > >diff --git a/installer/data/mysql/atomicupdate/bug18736_add_rounding_syspref.perl b/installer/data/mysql/atomicupdate/bug18736_add_rounding_syspref.perl >new file mode 100644 >index 0000000..0f3c77f >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug18736_add_rounding_syspref.perl >@@ -0,0 +1,7 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ # $dbh->do( "INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('OrderPriceRounding',NULL,'Local preference for rounding orders before calculations to ensure correct calculations','|nearest_cent','Choice')" ); >+ >+ SetVersion( $DBversion ); >+ print "Upgrade to $DBversion done (Bug 18736 - Add syspref to control order rounding)\n"; >+} >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 23cefb8..5ed5c0a 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -406,6 +406,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('OpenLibraryCovers','0',NULL,'If ON Openlibrary book covers will be show','YesNo'), > ('OpenLibrarySearch','0',NULL,'If Yes Open Library search results will show in OPAC','YesNo'), > ('OrderPdfFormat','pdfformat::layout3pages','Controls what script is used for printing (basketgroups)','','free'), >+('OrderPriceRounding','','|nearest_cent','Local preference for rounding orders before calculations to ensure correct calculations','Choice'), > ('OverDriveCirculation','0','Enable client to see their OverDrive account','','YesNo'), > ('OverDriveClientKey','','Client key for OverDrive integration','30','Free'), > ('OverDriveClientSecret','','Client key for OverDrive integration','30','YesNo'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref >index dad79f3..838a35d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref >@@ -76,6 +76,13 @@ Acquisitions: > yes: Send > no: Don't send > - blind copy (BCC) to logged in user when sending serial or acquisitions claims notices. >+ - >+ - pref: OrderPriceRounding >+ default: '' >+ choices: >+ '': Don't round >+ nearest_cent: Round to nearest cent >+ - determines whether full precision values or rounded values should be used in price calculations > > Printing: > - >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18736
:
64061
|
64065
|
70187
|
70188
|
70189
|
70768
|
71062
|
71063
|
71627
|
71628
|
71629
|
71630
|
71631
|
71632
|
74335
|
74336
|
74337
|
74338
|
74339
|
74340
|
74341
|
74342
|
74370
|
74371
|
74374
|
74397
|
74398
|
74422
|
74427
|
74438
|
76979
|
76980
|
76981
|
76982
|
76983
|
76984
|
76985
|
76986
|
76987
|
76988
|
76989
|
76990
|
76991
|
77614
|
77615
|
77616
|
77617
|
77618
|
78101
|
78120
|
78981
|
78982
|
78983
|
78984
|
78985
|
78986
|
78987
|
78988
|
79087
|
79088
|
79089
|
79090
|
79091
|
79092
|
79093
|
79094
|
79098
|
79099
|
79100
|
79101
|
79102
|
79103
|
79104
|
79105
|
79187
|
79223
|
79562
|
79563
|
82967
|
82968
|
82969
|
82970
|
82971
|
82972
|
82973
|
82974
|
82975
|
82976
|
82977
|
83212
|
83213
|
83214
|
83973
|
83974
|
83975
|
83976
|
83977
|
83978
|
83979
|
83980
|
83981
|
83982
|
83983
|
83984
|
83985
|
86646
|
86647
|
86648
|
86649
|
86650
|
86651
|
86652
|
86653
|
86654
|
86655
|
86656
|
86657
|
86658