Bugzilla – Attachment 70197 Details for
Bug 19807
IntranetCatalogSearchPulldown doesn't honor IntranetNumbersPreferPhrase
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase
Bug-19807-Make-IntranetCatalogSearchPulldown-honor.patch (text/plain), 3.19 KB, created by
Katrin Fischer
on 2017-12-29 06:45:41 UTC
(
hide
)
Description:
Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-12-29 06:45:41 UTC
Size:
3.19 KB
patch
obsolete
>From 54480ad663998d110c39b43d4b029d19cd6c7595 Mon Sep 17 00:00:00 2001 >From: Victor Grousset <victor.grousset@biblibre.com> >Date: Wed, 13 Dec 2017 20:16:54 +0100 >Subject: [PATCH] Bug 19807: Make IntranetCatalogSearchPulldown honor > IntranetNumbersPreferPhrase >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch >- fixes callnum and sn >- Removes unecessary syspref transmission to the template. > As the template directly reads the syspref > >Test plan: >1. Set sysprefs IntranetCatalogSearchPulldown and > IntranetNumbersPreferPhrase to true >2. Go to staff:/cgi-bin/koha/catalogue/search.pl >3. "search for" â "call number" and write anything that won't match a > call number in the field >4. Then you should see > «No results match your search for 'callnum,phr: [...]» >5. Go to the staff homepage >6. Click on "Search the catalog" >7. Do the same search as previouly >8. Then you should see > «No results match your search for 'callnum,wrdl: [...]» > This shows that IntranetNumbersPreferPhrase isn't honored >9. Apply this patch >10. Redo the same two searches and see that phr will now be always used. > So IntranetNumbersPreferPhrase is honored > >Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > catalogue/search.pl | 3 --- > koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc | 5 +++-- > 2 files changed, 3 insertions(+), 5 deletions(-) > >diff --git a/catalogue/search.pl b/catalogue/search.pl >index 05d064b..9f75221 100755 >--- a/catalogue/search.pl >+++ b/catalogue/search.pl >@@ -191,9 +191,6 @@ my $lang = C4::Languages::getlanguage($cgi); > if (C4::Context->preference("marcflavour") eq "UNIMARC" ) { > $template->param('UNIMARC' => 1); > } >-if (C4::Context->preference("IntranetNumbersPreferPhrase")) { >- $template->param('numbersphr' => 1); >-} > > if($cgi->cookie("holdfor")){ > my $holdfor_patron = Koha::Patrons->find( $cgi->cookie("holdfor") ); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc >index 3544029..95d3684 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc >@@ -1,3 +1,4 @@ >+[% USE Koha %] > <select class="advsearch" name="idx"> > <option value="kw">Keyword</option> > <option value="kw,phr"> Keyword as phrase</option> >@@ -21,14 +22,14 @@ > [% END %] > <option value="bc">Barcode</option> > <option value="location">Shelving location</option> >- [% IF (numbersphr) %] >+ [% IF ( Koha.Preference('IntranetNumbersPreferPhrase') ) %] > <option value="sn,phr">Standard number</option> > [% ELSE %] > <option value="sn">Standard number</option> > [% END %] > <option value="nb"> ISBN</option> > <option value="ns"> ISSN</option> >- [% IF (numbersphr) %] >+ [% IF ( Koha.Preference('IntranetNumbersPreferPhrase') ) %] > <option value="callnum,phr"> Call number</option> > [% ELSE %] > <option value="callnum"> Call number</option> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19807
:
69782
|
70180
| 70197