Bugzilla – Attachment 70246 Details for
Bug 19910
Download report as 'Comma separated' is misleading
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19910 - Use the delimiter syspref to name download link
Bug-19910---Use-the-delimiter-syspref-to-name-down.patch (text/plain), 2.75 KB, created by
Nick Clemens (kidclamp)
on 2018-01-03 14:09:19 UTC
(
hide
)
Description:
Bug 19910 - Use the delimiter syspref to name download link
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2018-01-03 14:09:19 UTC
Size:
2.75 KB
patch
obsolete
>From 415a49445aa83f9d46e3628ce0411998364f785d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 3 Jan 2018 14:07:17 +0000 >Subject: [PATCH] Bug 19910 - Use the delimiter syspref to name download link > >To test: >1 - Set delimiter syspref to anything but comma >2 - Donwload report results as comma separated text >3 - They actually follow the syspref >4 - Apply patch >5 - Download link should now match pref selection >6 - Change pref, note link changes >7 - Verify things still work as expected >--- > .../intranet-tmpl/prog/en/includes/reports-toolbar.inc | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >index 00edf94..f55b9a8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >@@ -50,11 +50,22 @@ > [% BLOCK params %] > [% FOREACH param IN sql_params %]&sql_params=[% param %][% END %] > [% END %] >+ [% BLOCK separator_text %] >+ [% SWITCH Koha.Preference('delimiter') %] >+ [% CASE '#' %]Pound (#) separated text >+ [% CASE ',' %]Comma separated text >+ [% CASE '/' %]Slash separated text >+ [% CASE ';' %]Semicolon separated text >+ [% CASE '\\' %]Backslash separated text >+ [% CASE 'tabulation' %]Tab separated text >+ [% END %] >+ [% END %] >+ > > <div class="btn-group"> > <button class="btn btn-default btn-sm dropdown-toggle" data-toggle="dropdown" id="format"><i class="fa fa-upload"></i> Download <span class="caret"></span></button> > <ul class="dropdown-menu"> >- <li><a id="csv" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&format=csv&report_id=[% id %]&reportname=[% name |uri %][% PROCESS params %]">Comma separated text</a></li> >+ <li><a id="csv" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&format=csv&report_id=[% id %]&reportname=[% name |uri %][% PROCESS params %]">[% PROCESS separator_text %]</a></li> > <li><a id="tab" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&format=tab&report_id=[% id %]&reportname=[% name |uri %][% PROCESS params %]">Tab separated text</a></li> > <li><a id="ods" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&format=ods&report_id=[% id %]&reportname=[% name |uri %][% PROCESS params %]">Open Document Spreadsheet</a></li> > </ul> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19910
:
70246
|
70643
|
70977
|
73494
|
73518
|
73592
|
73658