Attachment 70265 Details for Bug 12598 – Bug 12598: Remove warnings from tests and make them pass

[patch] Bug 12598: Remove warnings from tests and make them pass

Bug-12598-Remove-warnings-from-tests-and-make-them.patch (text/plain), 1.92 KB, created by Jonathan Druart on 2018-01-04 13:07:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-01-04 13:07:04 UTC

Size: 1.92 KB

patch

obsolete

>From 303aa74844c4884e9af2ce36a7353e36b33cf814 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 4 Jan 2018 10:05:46 -0300
>Subject: [PATCH] Bug 12598: Remove warnings from tests and make them pass
>
>---
> Koha/Patrons/Import.pm               | 4 ++--
> t/db_dependent/Koha/Patrons/Import.t | 1 -
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm
>index 4af3cd6db2..db77a3be7b 100644
>--- a/Koha/Patrons/Import.pm
>+++ b/Koha/Patrons/Import.pm
>@@ -167,7 +167,7 @@ sub import_patrons {
>         if ( defined($matchpoint) && ( $matchpoint eq 'cardnumber' ) && ( $borrower{'cardnumber'} ) ) {
>             $member = Koha::Patrons->find( { cardnumber => $borrower{'cardnumber'} } );
>         }
>-        elsif ( ($matchpoint eq 'userid') && ($borrower{'userid'}) ) {
>+        elsif ( defined($matchpoint) && ($matchpoint eq 'userid') && ($borrower{'userid'}) ) {
>             $member = Koha::Patrons->find( { userid => $borrower{userid} } );
>         }
>         elsif ($extended) {
>@@ -201,7 +201,7 @@ sub import_patrons {
>         }
> 
>         # Check if the userid provided does not exist yet
>-        if (  $matchpoint ne 'userid' and exists $borrower{userid}
>+        if ( defined($matchpoint) and $matchpoint ne 'userid' and exists $borrower{userid}
>                  and $borrower{userid}
>              and not Check_Userid( $borrower{userid}, $borrower{borrowernumber} ) ) {
>              push @errors, { duplicate_userid => 1, userid => $borrower{userid} };
>diff --git a/t/db_dependent/Koha/Patrons/Import.t b/t/db_dependent/Koha/Patrons/Import.t
>index 4e4bde49f5..e5738bb021 100644
>--- a/t/db_dependent/Koha/Patrons/Import.t
>+++ b/t/db_dependent/Koha/Patrons/Import.t
>@@ -317,7 +317,6 @@ subtest 'test_prepare_columns' => sub {
>     plan tests => 16;
> 
>     # Given ... no header row
>-    my $headerrow_0;
>     my %csvkeycol_0;
>     my @errors_0;
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 12598: 29807 | 29808 | 29809 | 29939 | 30755 | 30780 | 35557 | 35558 | 35559 | 35560 | 35848 | 35849 | 35850 | 35851 | 35964 | 36684 | 36685 | 36687 | 36688 | 36690 | 36692 | 36693 | 36694 | 36695 | 36696 | 39124 | 39125 | 39126 | 39127 | 39128 | 41790 | 41791 | 41792 | 41793 | 41794 | 44065 | 44066 | 44067 | 44068 | 44069 | 48753 | 48754 | 48755 | 48756 | 48757 | 50693 | 50694 | 50695 | 50696 | 50697 | 50698 | 50699 | 50700 | 50704 | 51122 | 51357 | 51358 | 51359 | 51360 | 51361 | 51362 | 51363 | 51364 | 51365 | 51366 | 51367 | 51368 | 51369 | 51370 | 51371 | 51372 | 52323 | 52324 | 52325 | 52326 | 52327 | 52328 | 52329 | 52330 | 52331 | 52332 | 52333 | 52540 | 64437 | 64438 | 64855 | 65214 | 65215 | 65216 | 65217 | 65218 | 65819 | 65820 | 65821 | 65822 | 65823 | 65824 | 66353 | 66354 | 66355 | 66356 | 66357 | 66358 | 66359 | 66575 | 66576 | 66577 | 66578 | 66579 | 66580 | 66581 | 66582 | 67276 | 67277 | 70265 | 70266 | 71755 | 71756 | 71757 | 71758 | 71759 | 71760 | 71761 | 71762 | 71763 | 71764 | 71765 | 71766