Bugzilla – Attachment 70281 Details for
Bug 17833
_initilize_memcached() warns if errors
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17833 - _initilize_memcached() warns if errors
Bug-17833---initilizememcached-warns-if-errors.patch (text/plain), 1.31 KB, created by
Marcel de Rooy
on 2018-01-05 07:55:32 UTC
(
hide
)
Description:
Bug 17833 - _initilize_memcached() warns if errors
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-01-05 07:55:32 UTC
Size:
1.31 KB
patch
obsolete
>From 82668db3de3e67d47e038d34f588fcf8c10682de Mon Sep 17 00:00:00 2001 >From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> >Date: Mon, 2 Jan 2017 13:01:02 +0200 >Subject: [PATCH] Bug 17833 - _initilize_memcached() warns if errors >Content-Type: text/plain; charset=utf-8 > >If memcached or the connection to it is misconfigured, show simple warnings to help >identify the problem. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Cache.pm | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/Koha/Cache.pm b/Koha/Cache.pm >index 5af8c0e..5bab842 100644 >--- a/Koha/Cache.pm >+++ b/Koha/Cache.pm >@@ -139,9 +139,13 @@ sub _initialize_memcached { > utf8 => 1, > } > ); >+ > # Ensure we can actually talk to the memcached server > my $ismemcached = $memcached->set('ismemcached','1'); >- return $self unless $ismemcached; >+ unless ($ismemcached) { #Value is undefined or False, so there was an error with the server, the connection to it, or a protocol error >+ warn "Connection to the memcached servers '@servers' failed. Are the unix socket permissions set properly? Is the host reachable?"; >+ return $self; >+ } > $self->{'memcached_cache'} = $memcached; > return $self; > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17833
:
58554
|
58556
|
68162
| 70281 |
70307