Bugzilla – Attachment 70374 Details for
Bug 19936
Move Check_userid and Generate_Userid to Koha::Patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19936: Remove warnings from tests
Bug-19936-Remove-warnings-from-tests.patch (text/plain), 949 bytes, created by
Jonathan Druart
on 2018-01-09 14:53:59 UTC
(
hide
)
Description:
Bug 19936: Remove warnings from tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-01-09 14:53:59 UTC
Size:
949 bytes
patch
obsolete
>From 1afdb0e53c7090d4ea22940661e5bf4023d9dbf4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 9 Jan 2018 10:33:25 -0300 >Subject: [PATCH] Bug 19936: Remove warnings from tests > >C4::Members did not "use warnings;" >--- > Koha/Patron.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index 7d95bd75c9..c53d0c6d77 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -764,8 +764,8 @@ sub generate_userid { > my $userid; > my $offset = 0; > my $patron = Koha::Patron->new; >- my $firstname = $self->firstname; >- my $surname = $self->surname; >+ my $firstname = $self->firstname // q{}; >+ my $surname = $self->surname // q{}; > #The script will "do" the following code and increment the $offset until the generated userid is unique > do { > $firstname =~ s/[[:digit:][:space:][:blank:][:punct:][:cntrl:]]//g; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19936
:
70365
|
70366
|
70367
|
70368
|
70369
|
70370
|
70371
|
70372
|
70373
|
70374
|
71787
|
71788
|
71789
|
71790
|
71791
|
71792
|
71793
|
71794
|
71795
|
71796
|
72129
|
72130
|
72131
|
72132
|
72133
|
72134
|
72135
|
72136
|
72137
|
72138
|
72139
|
72140
|
72141
|
72142
|
72143
|
72144
|
72145
|
72146
|
72147
|
72148
|
72149
|
72150
|
72151
|
72152
|
73630
|
73631
|
73632
|
73633
|
73634
|
73635
|
73636
|
73637
|
73638
|
73639
|
73640
|
73641
|
73963
|
73964
|
73965
|
73966
|
73967
|
73968
|
73969
|
73970
|
73971
|
73972
|
73973
|
73974
|
74071
|
74072
|
74073
|
74074
|
74075
|
74076
|
74077
|
74078
|
74079
|
74080
|
74081
|
74082