Bugzilla – Attachment 70398 Details for
Bug 18856
Cancel Waiting Hold in OPAC does not give useful message
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18856: Don't show cancel option for waiting holds in OPAC
Bug-18856-Dont-show-cancel-option-for-waiting-hold.patch (text/plain), 2.57 KB, created by
Katrin Fischer
on 2018-01-10 07:24:17 UTC
(
hide
)
Description:
Bug 18856: Don't show cancel option for waiting holds in OPAC
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-01-10 07:24:17 UTC
Size:
2.57 KB
patch
obsolete
>From 6ab0e60149ef0bd63e701757d9e528ca6c5d562b Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 29 Sep 2017 13:43:58 -0400 >Subject: [PATCH] Bug 18856: Don't show cancel option for waiting holds in OPAC > >If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. >If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. >Staff can cancel the hold from the staff interface but they can then action the waiting hold. >I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. > >The template was using a method that tells Koha if *staff* can cancel a hold, >instead of patron. > >Test Plan: >1) Set up a waiting hold >2) Try to cancel it from the opac >3) Note you cannot >4) Apply this patch >5) Reload the page >6) Note the cancel button has disappeared for found holds > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 35cf5a0..77e601b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -740,7 +740,7 @@ Using this account is not recommended because some parts of Koha will not functi > </td> > [% END # / IF SuspendHoldsOpac %] > <td class="modify"> >- [% IF ( RESERVE.is_cancelable ) %] >+ [% IF ( ! RESERVE.is_found ) %] > <form action="/cgi-bin/koha/opac-modrequest.pl" method="post"> > <input type="hidden" name="biblionumber" value="[% RESERVE.biblionumber %]" /> > <input type="hidden" name="reserve_id" value="[% RESERVE.reserve_id %]" /> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18856
:
67480
|
67520
|
69077
|
70294
|
70398
|
70399
|
70419
|
70424
|
70425
|
75394
|
75395