Bugzilla – Attachment 70407 Details for
Bug 19804
Suspension calculation doesn't honor 'Suspension charging interval'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19804: Add the new column to the circ rules interface
Bug-19804-Add-the-new-column-to-the-circ-rules-int.patch (text/plain), 3.75 KB, created by
Hugo Agud
on 2018-01-10 15:07:57 UTC
(
hide
)
Description:
Bug 19804: Add the new column to the circ rules interface
Filename:
MIME Type:
Creator:
Hugo Agud
Created:
2018-01-10 15:07:57 UTC
Size:
3.75 KB
patch
obsolete
>From 4161057eec1fe3d69463199a418d97d54c544b8c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 13 Dec 2017 18:05:50 -0300 >Subject: [PATCH] Bug 19804: Add the new column to the circ rules interface > >Signed-off-by: Hugo Agud <hagud@orex.es> >--- > admin/smart-rules.pl | 2 ++ > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 4 ++++ > 2 files changed, 6 insertions(+) > >diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl >index 6a55b7b..e5e986e 100755 >--- a/admin/smart-rules.pl >+++ b/admin/smart-rules.pl >@@ -126,6 +126,7 @@ elsif ($op eq 'add') { > my $finedays = $input->param('finedays'); > my $maxsuspensiondays = $input->param('maxsuspensiondays'); > $maxsuspensiondays = undef if $maxsuspensiondays eq q||; >+ my $suspension_chargeperiod = $input->param('suspension_chargeperiod') || 1; > my $firstremind = $input->param('firstremind'); > my $chargeperiod = $input->param('chargeperiod'); > my $chargeperiod_charge_at = $input->param('chargeperiod_charge_at'); >@@ -169,6 +170,7 @@ elsif ($op eq 'add') { > fine => $fine, > finedays => $finedays, > maxsuspensiondays => $maxsuspensiondays, >+ suspension_chargeperiod => $suspension_chargeperiod, > firstremind => $firstremind, > chargeperiod => $chargeperiod, > chargeperiod_charge_at => $chargeperiod_charge_at, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index 6dc5042..310161c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -78,6 +78,7 @@ > <th>Cap fine at replacement price</th> > <th>Suspension in days (day)</th> > <th>Max. suspension duration (day)</th> >+ <th>Fine day charging interval</th> > <th>Renewals allowed (count)</th> > <th>Renewal period</th> > <th>No renewal before</th> >@@ -159,6 +160,7 @@ > </td> > <td>[% rule.finedays %]</td> > <td>[% rule.maxsuspensiondays %]</td> >+ <td>[% rule.suspension_chargeperiod %]</td> > <td>[% rule.renewalsallowed %]</td> > <td>[% rule.renewalperiod %]</td> > <td>[% rule.norenewalbefore %]</td> >@@ -254,6 +256,7 @@ > <td><input type="checkbox" name="cap_fine_to_replacement_price" id="cap_fine_to_replacement_price" /></td> > <td><input type="text" name="finedays" id="fined" size="3" /> </td> > <td><input type="text" name="maxsuspensiondays" id="maxsuspensiondays" size="3" /> </td> >+ <td><input type="text" name="suspension_chargeperiod" id="suspension_chargeperiod" size="3" /> </td> > <td><input type="text" name="renewalsallowed" id="renewalsallowed" size="2" /></td> > <td><input type="text" name="renewalperiod" id="renewalperiod" size="3" /></td> > <td><input type="text" name="norenewalbefore" id="norenewalbefore" size="3" /></td> >@@ -316,6 +319,7 @@ > <th>Overdue fines cap (amount)</th> > <th>Cap fine at replacement price</th> > <th>Suspension in days (day)</th> >+ <th>Fine day charging interval</th> > <th>Max. suspension duration (day)</th> > <th>Renewals allowed (count)</th> > <th>Renewal period</th> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19804
:
69783
|
69784
|
69785
|
69786
|
70404
|
70405
|
70406
|
70407
|
73665
|
73666
|
73667
|
73830
|
73831
|
73832
|
73833
|
73834
|
73894
|
73895