Bugzilla – Attachment 70542 Details for
Bug 18083
Don't show 'library' selection on popular titles page for single-branch libraries
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18083: Don't show 'library' selection on popular titles page for single-branch libraries
Bug-18083-Dont-show-library-selection-on-popular-t.patch (text/plain), 2.16 KB, created by
Te Rauhina Jackson
on 2018-01-16 03:22:18 UTC
(
hide
)
Description:
Bug 18083: Don't show 'library' selection on popular titles page for single-branch libraries
Filename:
MIME Type:
Creator:
Te Rauhina Jackson
Created:
2018-01-16 03:22:18 UTC
Size:
2.16 KB
patch
obsolete
>From 135794228d792588eb101e6b92cd2d6611b43be7 Mon Sep 17 00:00:00 2001 >From: Te Rauhina Jackson <terauhina.jackson@gmail.com> >Date: Tue, 16 Jan 2018 03:03:47 +0000 >Subject: [PATCH] Bug 18083: Don't show 'library' selection on popular titles > page for single-branch libraries > >This patch hides the search filter labelled "From" that offers you to >select a library branch which is located on the 'popular titles' page on the OPAC. It is hidden when the library only has one branchas it would be unneccessary to have an option for other branches when there is only one. > >Test Plan: >1) Make sure you have a single-branch library >2) Make sure OPACTopIssue is allowed in the OPAC preferences >3) In the OPAC, got to 'Most Popular' page >4) Check that there is no "From" filter in the refine search >5) Create a new branch so that you have more than one branch >6) Check that there is a "From" filter in the refine search on the Most Popular page. >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc >index 2ce6921..6e9b133 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc >@@ -17,11 +17,13 @@ > [% IF ( limit == 100 ) %]<option value ="100" selected="selected">100 titles</option>[% ELSE %]<option value="100">100 titles</option>[% END %] > </select></li> > >+ [% UNLESS Branches.all.size == 1 %] > <li><label for="branch">From: </label> > <select name="branch" id="branch"> > <option value="">All libraries</option> > [% PROCESS options_for_libraries libraries => Branches.all( selected => branch ) %] > </select></li> >+ [% END %] > > [% AdvancedSearchTypes = Koha.Preference('AdvancedSearchTypes').split('\|') %] > [% IF AdvancedSearchTypes.grep('^itemtypes$').size %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18083
:
70542
|
70623
|
70771