Attachment 70567 Details for Bug 19938 – Bug 19938: Bad return value triggers noise

[patch] Bug 19938: Bad return value triggers noise

Bug-19938-Bad-return-value-triggers-noise.patch (text/plain), 1.55 KB, created by Mark Tompsett on 2018-01-16 19:35:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2018-01-16 19:35:43 UTC

Size: 1.55 KB

patch

obsolete

>From e4b82e09e717715124c2b3a7809c2b7f06529d0a Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Tue, 16 Jan 2018 19:32:30 +0000
>Subject: [PATCH] Bug 19938: Bad return value triggers noise
>
>TEST PLAN
>---------
>0) back up plack error log if you care.
>
>1) Run these on your kohadevbox:
>    echo | sudo tee /var/log/koha/kohadev/plack-error.log
>    sudo koha-shell -c bash kohadev
>    prove t/db_dependent/Circulation/dateexpiry.t
>    prove t/db_dependent/www/search_utf8.t
>    ./misc/cronjobs/staticfines.pl
>    exit
>
>    They will all pass or run without error.
>    However, the log file will have noise.
>
>2) Run these on your kohadevbox:
>    git bz apply 19938
>    restart_all
>    echo | sudo tee /var/log/koha/kohadev/plack-error.log
>    sudo koha-shell -c bash kohadev
>    prove t/db_dependent/Circulation/dateexpiry.t
>    prove t/db_dependent/www/search_utf8.t
>    ./misc/cronjobs/staticfines.pl
>    exit
>
>    They will all pass or run without error.
>    This time the log file will have no noise.
>
>3) run koha qa test tools
>---
> C4/Overdues.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Overdues.pm b/C4/Overdues.pm
>index 6b75e38..8d42d3b 100644
>--- a/C4/Overdues.pm
>+++ b/C4/Overdues.pm
>@@ -152,7 +152,7 @@ Returns a count and a list of overdueitems for a given borrowernumber
> =cut
> 
> sub checkoverdues {
>-    my $borrowernumber = shift or return;
>+    my $borrowernumber = shift or return (0,{});
>     my $sth = C4::Context->dbh->prepare(
>         "SELECT biblio.*, items.*, issues.*,
>                 biblioitems.volume,
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19938: 70375 | 70382 | 70383 | 70396 | 70397 | 70472 | 70473 | 70485 | 70486 | 70489 | 70567