Bugzilla – Attachment 70610 Details for
Bug 19784
Adapt /v1/patrons to new naming guidelines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19784: Remove reference to 'borrowernumber' param from other endpoints
Bug-19784-Remove-reference-to-borrowernumber-param.patch (text/plain), 2.68 KB, created by
Tomás Cohen Arazi (tcohen)
on 2018-01-17 13:20:10 UTC
(
hide
)
Description:
Bug 19784: Remove reference to 'borrowernumber' param from other endpoints
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2018-01-17 13:20:10 UTC
Size:
2.68 KB
patch
obsolete
>From 04eb4664fc5b8e99651fc190539344e7fdecfdfd Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 8 Dec 2017 09:25:35 -0300 >Subject: [PATCH] Bug 19784: Remove reference to 'borrowernumber' param from > other endpoints > >This patch removes the $ref occurences for borrowernumber in not >patron-specific endpoints. 'borrowernumber' is still used on them, but as a >hardcoded parameter. The param rename will happen on a separate bug for >each endpoint. >--- > api/v1/swagger/definitions/hold.json | 3 ++- > api/v1/swagger/paths/holds.json | 7 +++++-- > api/v1/swagger/paths/illrequests.json | 6 +++++- > 3 files changed, 12 insertions(+), 4 deletions(-) > >diff --git a/api/v1/swagger/definitions/hold.json b/api/v1/swagger/definitions/hold.json >index 8f91aed964..626910beb7 100644 >--- a/api/v1/swagger/definitions/hold.json >+++ b/api/v1/swagger/definitions/hold.json >@@ -5,7 +5,8 @@ > "$ref": "../x-primitives.json#/reserve_id" > }, > "borrowernumber": { >- "$ref": "../x-primitives.json#/borrowernumber" >+ "type": "integer", >+ "description": "Internal patron identifier" > }, > "reservedate": { > "type": ["string", "null"], >diff --git a/api/v1/swagger/paths/holds.json b/api/v1/swagger/paths/holds.json >index b2f542ac40..390997dff7 100644 >--- a/api/v1/swagger/paths/holds.json >+++ b/api/v1/swagger/paths/holds.json >@@ -12,7 +12,10 @@ > "type": "integer" > }, > { >- "$ref": "../parameters.json#/borrowernumberQueryParam" >+ "name": "borrowernumber", >+ "in": "query", >+ "description": "Internal patron identifier", >+ "type": "integer" > }, > { > "name": "reservedate", >@@ -171,7 +174,7 @@ > "type": "object", > "properties": { > "borrowernumber": { >- "description": "Borrower internal identifier", >+ "description": "Internal patron identifier", > "type": "integer" > }, > "biblionumber": { >diff --git a/api/v1/swagger/paths/illrequests.json b/api/v1/swagger/paths/illrequests.json >index 21fd76b9a5..13ec426fce 100644 >--- a/api/v1/swagger/paths/illrequests.json >+++ b/api/v1/swagger/paths/illrequests.json >@@ -39,7 +39,11 @@ > "required": false, > "type": "integer" > }, { >- "$ref": "../parameters.json#/borrowernumberQueryParam" >+ "name": "borrowernumber", >+ "in": "query", >+ "description": "Internal patron identifier", >+ "required": false, >+ "type": "integer" > }, { > "name": "completed", > "in": "query", >-- >2.15.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19784
:
69643
|
69644
|
69645
|
69753
|
69754
|
69755
|
70609
|
70610
|
70611
|
70612
|
71768
|
71769
|
71770
|
71959
|
71960
|
71961
|
71967
|
71968
|
71969
|
72026
|
72027
|
72028
|
72171
|
72172
|
72173