Attachment 70614 Details for Bug 18811 – Bug 18811: (QA follow-up) Allow hidden $9 subfields

[patch] Bug 18811: (QA follow-up) Allow hidden $9 subfields

Bug-18811-QA-follow-up-Allow-hidden-9-subfields.patch (text/plain), 3.10 KB, created by Marcel de Rooy on 2018-01-17 13:32:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2018-01-17 13:32:24 UTC

Size: 3.10 KB

patch

obsolete

>From 86a576daffcf2e7fceddaaf4cb0b8847387d22f9 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 17 Jan 2018 14:26:38 +0100
>Subject: [PATCH] Bug 18811: (QA follow-up) Allow hidden $9 subfields
>Content-Type: text/plain; charset=utf-8
>
>Although we could argue that the user should make all $9 subfields
>visible, this might be a good compromise. It selectively reverts the
>change from the first patch by accepting $9 subfields without checking
>the hidden flag in the framework.
>
>Test plan:
>[1] Make a subfield $9 visible for some authority field.
>[2] Put a value in it somewhere in authorities.pl
>[3] Make subfield $9 invisible in the auth framework.
>[4] Open and save the adjusted authority record.
>[5] Check the marcxml of this record.
>---
> authorities/authorities.pl | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/authorities/authorities.pl b/authorities/authorities.pl
>index 84fba09..7ffb010 100755
>--- a/authorities/authorities.pl
>+++ b/authorities/authorities.pl
>@@ -404,7 +404,7 @@ sub build_tabs {
>                             $subfield = '@';
>                         }
>                         next if ( $tagslib->{$tag}->{$subfield}->{tab} ne $tabloop );
>-                        next if $tagslib->{$tag}->{$subfield}->{hidden};
>+                        next if $tagslib->{$tag}->{$subfield}->{hidden} && $subfield ne '9';
>                         push(
>                             @subfields_data,
>                             &create_input(
>@@ -420,7 +420,7 @@ sub build_tabs {
>                             my $value    = $subfields[$subfieldcount][1];
>                             next if ( length $subfield != 1 );
>                             next if ( $tagslib->{$tag}->{$subfield}->{tab} ne $tabloop );
>-                            next if $tagslib->{$tag}->{$subfield}->{hidden};
>+                            next if $tagslib->{$tag}->{$subfield}->{hidden} && $subfield ne '9';
>                             push(
>                                 @subfields_data,
>                                 &create_input(
>@@ -437,7 +437,7 @@ sub build_tabs {
>                         next if ( length $subfield != 1 );
>                         next if ( $tagslib->{$tag}->{$subfield}->{tab} ne $tabloop );
>                         next if ( $tag < 10 );
>-                        next if $tagslib->{$tag}->{$subfield}->{hidden};
>+                        next if $tagslib->{$tag}->{$subfield}->{hidden} && $subfield ne '9';
>                         next if ( defined( $field->subfield($subfield) ) );
>                         push(
>                             @subfields_data,
>@@ -476,7 +476,7 @@ sub build_tabs {
>                 my @subfields_data;
>                 foreach my $subfield ( sort( keys %{ $tagslib->{$tag} } ) ) {
>                     next if ( length $subfield != 1 );
>-                    next if $tagslib->{$tag}->{$subfield}->{hidden};
>+                    next if $tagslib->{$tag}->{$subfield}->{hidden} && $subfield ne '9';
>                     next if ( $tagslib->{$tag}->{$subfield}->{tab} ne $tabloop );
>                     push(
>                         @subfields_data,
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18811: 64314 | 64541 | 64542 | 64570 | 64571 | 64572 | 64573 | 66309 | 66310 | 66311 | 66312 | 66708 | 66709 | 66710 | 66711 | 66793 | 66794 | 70614