Bugzilla – Attachment 70616 Details for
Bug 19989
opac-memberentry.pl has a FIXME that can be fixed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19989: fixing the FIXME so that new requests replace old request
Bug-19989-fixing-the-FIXME-so-that-new-requests-re.patch (text/plain), 1.50 KB, created by
Owen Leonard
on 2018-01-17 13:42:59 UTC
(
hide
)
Description:
Bug 19989: fixing the FIXME so that new requests replace old request
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2018-01-17 13:42:59 UTC
Size:
1.50 KB
patch
obsolete
>From 56594e80838780c8f2d068b5cb34cb2194991e80 Mon Sep 17 00:00:00 2001 >From: Zoe Bennett <zoebennett1308@gmail.com> >Date: Wed, 17 Jan 2018 04:01:01 +0000 >Subject: [PATCH] Bug 19989: fixing the FIXME so that new requests replace old > request > >Test: >1) Make a change to the user in the OPAC >2) In the staff client make sure this is the only request > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > opac/opac-memberentry.pl | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > >diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl >index 12eebbb..c680d7d 100755 >--- a/opac/opac-memberentry.pl >+++ b/opac/opac-memberentry.pl >@@ -272,13 +272,7 @@ elsif ( $action eq 'update' ) { > $borrower_changes{borrowernumber} = $borrowernumber; > $borrower_changes{extended_attributes} = to_json($extended_attributes_changes); > >- # FIXME update the following with >- # Koha::Patron::Modifications->search({ borrowernumber => $borrowernumber })->delete; >- # when bug 17091 will be pushed >- my $patron_modifications = Koha::Patron::Modifications->search({ borrowernumber => $borrowernumber }); >- while ( my $patron_modification = $patron_modifications->next ) { >- $patron_modification->delete; >- } >+ my $patron_modifications = Koha::Patron::Modifications->search({ borrowernumber => $borrowernumber })->delete; > > my $m = Koha::Patron::Modification->new( \%borrower_changes )->store(); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19989
:
70600
|
70616
|
71201