Bugzilla – Attachment 70663 Details for
Bug 19997
use Modern::Perl in Circulation perl scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19997: use Modern::Perl in Circulation perl scripts
Bug-19997-use-ModernPerl-in-Circulation-perl-scrip.patch (text/plain), 6.52 KB, created by
Charlotte Cordwell
on 2018-01-18 01:59:31 UTC
(
hide
)
Description:
Bug 19997: use Modern::Perl in Circulation perl scripts
Filename:
MIME Type:
Creator:
Charlotte Cordwell
Created:
2018-01-18 01:59:31 UTC
Size:
6.52 KB
patch
obsolete
>From b22934c85a76b98384db0e040b47a6957aa5c3ac Mon Sep 17 00:00:00 2001 >From: Charlotte Cordwell <charlotte.cordwell123@gmail.com> >Date: Thu, 18 Jan 2018 01:57:32 +0000 >Subject: [PATCH] Bug 19997: use Modern::Perl in Circulation perl scripts > >Test Case: >Check the following files have been updated from >use strict; >use warnings; >to >use Modern::Perl; > >bookcount.pl >branchoverdues.pl >branchtransfers.pl >circulation.pl >hold-transfer-slip.pl >reserveratios.pl >returns.pl >selectbranchprinter.pl >transfer-slip.pl >transferstoreceive.pl >view_holdsqueue.pl >waitingreserves.pl >ypattrodue-attr-search-authvalue.pl >--- > circ/bookcount.pl | 3 +-- > circ/branchoverdues.pl | 3 +-- > circ/branchtransfers.pl | 3 +-- > circ/circulation.pl | 3 +-- > circ/hold-transfer-slip.pl | 3 +-- > circ/reserveratios.pl | 3 +-- > circ/returns.pl | 3 +-- > circ/selectbranchprinter.pl | 3 +-- > circ/transfer-slip.pl | 3 +-- > circ/transferstoreceive.pl | 3 +-- > circ/view_holdsqueue.pl | 3 +-- > circ/waitingreserves.pl | 3 +-- > circ/ypattrodue-attr-search-authvalue.pl | 5 ++--- > 13 files changed, 14 insertions(+), 27 deletions(-) > >diff --git a/circ/bookcount.pl b/circ/bookcount.pl >index 2976a05..3543d92 100755 >--- a/circ/bookcount.pl >+++ b/circ/bookcount.pl >@@ -20,8 +20,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-#use warnings; FIXME - Bug 2505 >+use Modern::Perl; > use CGI qw ( -utf8 ); > use C4::Debug; > use C4::Context; >diff --git a/circ/branchoverdues.pl b/circ/branchoverdues.pl >index 29aad88..d4c20cb 100755 >--- a/circ/branchoverdues.pl >+++ b/circ/branchoverdues.pl >@@ -16,8 +16,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-#use warnings; FIXME - Bug 2505 >+use Modern::Perl; > use C4::Context; > use CGI qw ( -utf8 ); > use C4::Output; >diff --git a/circ/branchtransfers.pl b/circ/branchtransfers.pl >index c1d30cb..c9791cc 100755 >--- a/circ/branchtransfers.pl >+++ b/circ/branchtransfers.pl >@@ -20,8 +20,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > use CGI qw ( -utf8 ); > use C4::Circulation; > use C4::Output; >diff --git a/circ/circulation.pl b/circ/circulation.pl >index 5dc5d89..d074c8f 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -24,8 +24,7 @@ > > # FIXME There are too many calls to Koha::Patrons->find in this script > >-use strict; >-use warnings; >+use Modern::Perl; > use CGI qw ( -utf8 ); > use DateTime; > use DateTime::Duration; >diff --git a/circ/hold-transfer-slip.pl b/circ/hold-transfer-slip.pl >index bd09e21..115a434 100755 >--- a/circ/hold-transfer-slip.pl >+++ b/circ/hold-transfer-slip.pl >@@ -18,8 +18,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-#use warnings; FIXME - Bug 2505 >+use Modern::Perl; > use C4::Context; > use C4::Output; > use CGI qw ( -utf8 ); >diff --git a/circ/reserveratios.pl b/circ/reserveratios.pl >index cea63eb..104928a 100755 >--- a/circ/reserveratios.pl >+++ b/circ/reserveratios.pl >@@ -18,8 +18,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > > use CGI qw ( -utf8 ); > use Date::Calc qw/Today Add_Delta_YM/; >diff --git a/circ/returns.pl b/circ/returns.pl >index 677c91e..d4a6b8c 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -27,8 +27,7 @@ script to execute returns of books > > =cut > >-use strict; >-use warnings; >+use Modern::Perl; > > # FIXME There are weird things going on with $patron and $borrowernumber in this script > >diff --git a/circ/selectbranchprinter.pl b/circ/selectbranchprinter.pl >index 8099a38..03fa65b 100755 >--- a/circ/selectbranchprinter.pl >+++ b/circ/selectbranchprinter.pl >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > use CGI qw ( -utf8 ); > > use C4::Context; >diff --git a/circ/transfer-slip.pl b/circ/transfer-slip.pl >index 5211672..8ffbeaa 100755 >--- a/circ/transfer-slip.pl >+++ b/circ/transfer-slip.pl >@@ -18,8 +18,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > > use C4::Context; > use C4::Output; >diff --git a/circ/transferstoreceive.pl b/circ/transferstoreceive.pl >index 0929ed3..de6a89a 100755 >--- a/circ/transferstoreceive.pl >+++ b/circ/transferstoreceive.pl >@@ -18,8 +18,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > use CGI qw ( -utf8 ); > use C4::Context; > use C4::Output; >diff --git a/circ/view_holdsqueue.pl b/circ/view_holdsqueue.pl >index 3d8649a..bcacd50 100755 >--- a/circ/view_holdsqueue.pl >+++ b/circ/view_holdsqueue.pl >@@ -22,8 +22,7 @@ This script displays items in the tmp_holdsqueue table > > =cut > >-use strict; >-use warnings; >+use Modern::Perl; > use CGI qw ( -utf8 ); > use C4::Auth; > use C4::Output; >diff --git a/circ/waitingreserves.pl b/circ/waitingreserves.pl >index 332c5dd..24e0347 100755 >--- a/circ/waitingreserves.pl >+++ b/circ/waitingreserves.pl >@@ -18,8 +18,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > use CGI qw ( -utf8 ); > use C4::Context; > use C4::Output; >diff --git a/circ/ypattrodue-attr-search-authvalue.pl b/circ/ypattrodue-attr-search-authvalue.pl >index 7834b3b..4e8e2b3 100755 >--- a/circ/ypattrodue-attr-search-authvalue.pl >+++ b/circ/ypattrodue-attr-search-authvalue.pl >@@ -18,8 +18,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > use CGI qw ( -utf8 ); > use C4::Context; > use C4::Auth qw/check_cookie_auth/; >@@ -56,4 +55,4 @@ while ( my $rec = $sth->fetchrow_hashref ) { > "}"; > $i++; > } >-print "]"; >\ No newline at end of file >+print "]"; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19997
:
70663
|
70665
|
70885
|
70894
|
71193