Bugzilla – Attachment 7071 Details for
Bug 7016
CanBookBeReserved uses GetItemsInfo unnecessarily
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed Followup
0001-Bug-7016-Followup-Add-new-GetItemnumberForBiblio-sub.patch (text/plain), 2.20 KB, created by
Ian Walls
on 2012-01-06 15:10:20 UTC
(
hide
)
Description:
Proposed Followup
Filename:
MIME Type:
Creator:
Ian Walls
Created:
2012-01-06 15:10:20 UTC
Size:
2.20 KB
patch
obsolete
>From 37e4b978419f62f620a76c94a27b417dfbb3dce4 Mon Sep 17 00:00:00 2001 >From: Ian Walls <ian.walls@bywatersolutions.com> >Date: Fri, 6 Jan 2012 09:53:49 -0500 >Subject: [PATCH] Bug 7016 Followup: Add new GetItemnumberForBiblio subroutine > >Adds a new subroutine in C4::Items, GetItemnumbersForBiblio, which takes a >single biblionumber, and returns an array of all the corresponding itemnumbers. > >This patch also replaces the usage of get_itemnumbers_of in C4::Reserves::CanBookBeReserved >with this new subroutine, as the output is more consistent with what we were >lookng for (this is what fixes the bug issue). >--- > C4/Items.pm | 21 +++++++++++++++++++++ > C4/Reserves.pm | 2 +- > 2 files changed, 22 insertions(+), 1 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 8802a4c..29ac390 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -70,6 +70,7 @@ BEGIN { > GetItemsInfo > GetItemsLocationInfo > GetHostItemsInfo >+ GetItemnumbersForBiblio > get_itemnumbers_of > get_hostitemnumbers_of > GetItemnumberFromBarcode >@@ -1499,6 +1500,26 @@ sub GetLastAcquisitions { > return @results; > } > >+=head2 GetItemnumberForBiblio >+ >+ my @itemnumbers = GetItemnumbersForBiblio($biblionumber); >+ >+Given a single biblionumber, return an array of all the corresponding itemnumbers >+ >+=cut >+ >+sub GetItemnumbersForBiblio { >+ my $biblionumber = shift; >+ my @items; >+ my $dbh = C4::Context->dbh; >+ my $sth = $dbh->prepare("SELECT itemnumber FROM items WHERE biblionumber = ?"); >+ $sth->execute($biblionumber); >+ while (my $result = $sth->fetchrow_hashref) { >+ push @items, $result->{'itemnumber'}; >+ } >+ return \@items; >+} >+ > =head2 get_itemnumbers_of > > my @itemnumbers_of = get_itemnumbers_of(@biblionumbers); >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 359bbad..37780a6 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -384,7 +384,7 @@ sub GetReservesFromBorrowernumber { > sub CanBookBeReserved{ > my ($borrowernumber, $biblionumber) = @_; > >- my @items = get_itemnumbers_of($biblionumber); >+ my @items = GetItemnumbersForBiblio($biblionumber); > #get items linked via host records > my @hostitems = get_hostitemnumbers_of($biblionumber); > if (@hostitems){ >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7016
:
5861
|
5998
|
5999
|
7071
|
9127
|
9128