Bugzilla – Attachment 70840 Details for
Bug 20000
use Modern::Perl in installer perl scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20000: Changing 'use strict: use warnings;' to 'use Modern::Perl;'
Bug-20000-Changing-use-strict-use-warnings-to-use-.patch (text/plain), 4.52 KB, created by
Owen Leonard
on 2018-01-23 14:24:07 UTC
(
hide
)
Description:
Bug 20000: Changing 'use strict: use warnings;' to 'use Modern::Perl;'
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2018-01-23 14:24:07 UTC
Size:
4.52 KB
patch
obsolete
>From 9fe0d9b74f9884c8023ec91dedd6beb6c8bc7fe3 Mon Sep 17 00:00:00 2001 >From: Zoe Bennett <zoebennett1308@gmail.com> >Date: Wed, 17 Jan 2018 22:42:59 +0000 >Subject: [PATCH] Bug 20000: Changing 'use strict: use warnings;' to 'use > Modern::Perl;' > >Test Plan: >- Check that it now says 'use Modern::Perl' and not 'use strict; use >warnings;' in the following installer perl scripts: > >data/mysql/backfill_statistics.pl >data/mysql/labels_upgrade.pl >data/mysql/patroncards_upgrade.pl >data/mysql/update22to30.pl >data/mysql/updatedatabase.pl >externalmodules.pl >html-template-to-template-toolkit.pl >install.pl > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > installer/data/mysql/backfill_statistics.pl | 3 +-- > installer/data/mysql/labels_upgrade.pl | 3 +-- > installer/data/mysql/patroncards_upgrade.pl | 3 +-- > installer/data/mysql/update22to30.pl | 3 +-- > installer/data/mysql/updatedatabase.pl | 3 +-- > installer/externalmodules.pl | 3 +-- > installer/html-template-to-template-toolkit.pl | 4 ++-- > installer/install.pl | 3 +-- > 8 files changed, 9 insertions(+), 16 deletions(-) > >diff --git a/installer/data/mysql/backfill_statistics.pl b/installer/data/mysql/backfill_statistics.pl >index d03b461..488255b 100755 >--- a/installer/data/mysql/backfill_statistics.pl >+++ b/installer/data/mysql/backfill_statistics.pl >@@ -3,8 +3,7 @@ > # Part of the Koha Library Software www.koha-community.org > # Licensed under the GPL. > >-use strict; >-use warnings; >+use Modern::Perl; > > # CPAN modules > use DBI; >diff --git a/installer/data/mysql/labels_upgrade.pl b/installer/data/mysql/labels_upgrade.pl >index 158a4ec..bb891b4 100755 >--- a/installer/data/mysql/labels_upgrade.pl >+++ b/installer/data/mysql/labels_upgrade.pl >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-#use strict; >-#use warnings; FIXME - Bug 2505 >+use Modern::Perl; > > use C4::Context; > >diff --git a/installer/data/mysql/patroncards_upgrade.pl b/installer/data/mysql/patroncards_upgrade.pl >index 5b128cd..d289cb5 100755 >--- a/installer/data/mysql/patroncards_upgrade.pl >+++ b/installer/data/mysql/patroncards_upgrade.pl >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-#use strict; >-#use warnings; FIXME - Bug 2505 >+use Modern::Perl; > > use C4::Context; > >diff --git a/installer/data/mysql/update22to30.pl b/installer/data/mysql/update22to30.pl >index f10ace9..0b53272 100755 >--- a/installer/data/mysql/update22to30.pl >+++ b/installer/data/mysql/update22to30.pl >@@ -11,8 +11,7 @@ > # - Would also be a good idea to offer to do a backup at this time... > > # NOTE: If you do something more than once in here, make it table driven. >-use strict; >-#use warnings; FIXME - Bug 2505 >+use Modern::Perl; > > # CPAN modules > use DBI; >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 57a1a00..7216983 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -27,8 +27,7 @@ > > # NOTE: Please keep the version in kohaversion.pl up-to-date! > >-use strict; >-use warnings; >+use Modern::Perl; > > use feature 'say'; > >diff --git a/installer/externalmodules.pl b/installer/externalmodules.pl >index 42eb4b7..d7afdb5 100755 >--- a/installer/externalmodules.pl >+++ b/installer/externalmodules.pl >@@ -4,9 +4,8 @@ > # It provides you not only the list of modules BUT ALSO the files that uses those modules. > # utf8 or warnings or other lib use are not taken into account at the moment. > >+use Modern::Perl; > >-use strict; >-use warnings; > use C4::Context; > my $dir=C4::Context->config('intranetdir'); > qx(grep -r "^ *use" $dir | grep -v "C4\|strict\|vars" >/tmp/modulesKoha.log); >diff --git a/installer/html-template-to-template-toolkit.pl b/installer/html-template-to-template-toolkit.pl >index 5f0e0ac..56516ee 100755 >--- a/installer/html-template-to-template-toolkit.pl >+++ b/installer/html-template-to-template-toolkit.pl >@@ -1,7 +1,7 @@ > #!/usr/bin/perl > >-use strict; >-use warnings; >+use Modern::Perl; >+ > use Carp; > use Data::Dumper; > >diff --git a/installer/install.pl b/installer/install.pl >index bf0b9d1..624b62a 100755 >--- a/installer/install.pl >+++ b/installer/install.pl >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > use diagnostics; > > use C4::InstallAuth; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20000
:
70648
|
70710
|
70711
|
70840
|
70841
|
71191
|
72297
|
83402
|
83672
|
84671