Attachment 70842 Details for Bug 20074 – Bug 20074: Fix hidden value in auth_subfields_structure

[patch] Bug 20074: Fix hidden value in auth_subfields_structure

Bug-20074-Fix-hidden-value-in-authsubfieldsstructu.patch (text/plain), 2.06 KB, created by Marcel de Rooy on 2018-01-23 14:24:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2018-01-23 14:24:20 UTC

Size: 2.06 KB

patch

obsolete

>From bf29dfd440d596908403181278b8e9204c87cb04 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Tue, 23 Jan 2018 15:16:35 +0100
>Subject: [PATCH] Bug 20074: Fix hidden value in auth_subfields_structure
>Content-Type: text/plain; charset=utf-8
>
>The template included an else branch where a value not equal to 0 or -5
>was interpreted as 0 (Show all).
>This effectively converted hidden values 1 and 8 to 0.
>This patch removes that else branch.
>
>Test plan:
>Toggle a authority field between Hide all and Show all. Check what happens.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
>index abff20e..bcc9af0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
>@@ -113,12 +113,10 @@
>                                     [%- IF ( loo.ohidden ==  0 ) -%]
>                                     <option value= "0" selected="selected">Show all</option>
>                                     <option value="-5">Hide all</option>
>-                                    [%- ELSIF ( loo.ohidden == -5 ) -%]
>-                                    <option value= "0">Show all</option>
>-                                    <option value="-5" selected="selected">Hide all</option>
>                                     [%- ELSE -%]
>+                                    [%# All other non-zero values mean: Hide %]
>                                     <option value= "0">Show all</option>
>-                                    <option value="-5">Hide all</option>
>+                                    <option value="-5" selected="selected">Hide all</option>
>                                     [%- END -%]
>                                 </select>
>                             </li>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20074: 70842 | 70843 | 70847 | 71926 | 71927 | 71928 | 72191 | 72192 | 72193 | 72209 | 128400