Attachment 70860 Details for Bug 20079 – Bug 20079: Display stack trace for development installations

[patch] Bug 20079: Display stack trace for development installations

Bug-20079-Display-stack-trace-for-development-inst.patch (text/plain), 1.48 KB, created by Jonathan Druart on 2018-01-23 18:56:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-01-23 18:56:56 UTC

Size: 1.48 KB

patch

obsolete

>From 4e838bc60d243e4774d450bf68aac5f641727f0a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 23 Jan 2018 15:54:41 -0300
>Subject: [PATCH] Bug 20079: Display stack trace for development installations
>
>"""The default value is development, which causes plackup to
>load the middleware components: AccessLog, StackTrace, and Lint unless
>--no-default-middleware is set."""
>
>Test plan:
>Confirm that the stack trace is displayed when something is wrong (die somewhere to test)
>for dev installations (inside a devbox)
>The -E flag must remain deployment for non-dev installs
>---
> debian/scripts/koha-plack | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/debian/scripts/koha-plack b/debian/scripts/koha-plack
>index 5e1fc9cf65..4fa90cca5e 100755
>--- a/debian/scripts/koha-plack
>+++ b/debian/scripts/koha-plack
>@@ -85,7 +85,13 @@ start_plack()
>                  --daemonize \
>                  --access-log /var/log/koha/${instancename}/plack.log \
>                  --error-log /var/log/koha/${instancename}/plack-error.log \
>-                 -E deployment --socket ${PLACKSOCKET} ${PSGIFILE}"
>+                 --socket ${PLACKSOCKET} ${PSGIFILE}"
>+
>+    if [ "$DEV_INSTALL" = "" ]; then
>+        STARMANOPTS="$STARMANOPTS -E deployment"
>+    else
>+        STARMANOPTS="$STARMANOPTS -E development"
>+    fi
> 
>     if ! is_plack_running ${instancename}; then
>         export KOHA_CONF="/etc/koha/sites/${instancename}/koha-conf.xml"
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20079: 70860 | 70862 | 72341 | 76892