Attachment 70914 Details for Bug 20084 – Bug 20084: fix Industrial2of5 and COOP2of5 patron card layouts

[patch] Bug 20084: fix Industrial2of5 and COOP2of5 patron card layouts

Bug-20084-fix-Industrial2of5-and-COOP2of5-patron-c.patch (text/plain), 2.78 KB, created by Victor Grousset/tuxayo on 2018-01-25 15:05:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2018-01-25 15:05:34 UTC

Size: 2.78 KB

patch

obsolete

>From ad190a473b1cbcd89b6af6ba004a45846b55201a Mon Sep 17 00:00:00 2001
>From: Victor Grousset <victor.grousset@biblibre.com>
>Date: Thu, 25 Jan 2018 14:37:56 +0100
>Subject: [PATCH] Bug 20084: fix Industrial2of5 and COOP2of5 patron card
> layouts
>
>== Test plan ==
>This is an oversimplification of a full patron card setup used in production.
>
>1. Create a batch with 1 patron
>2. Create a layout and set
>     the name
>     "Print card number as barcode"
>     "Barcode type:" to "Code 39"
>3. Create a card template without filling anything
>4. Export the batch using the layout and template
>5. You should have a white page with a barcode
>     And no errors in the relevant log file
>     This show that this setup isn't completely bogus
>     (although Code 39 is the only type working...)
>6. Layout: set "Barcode type:" to Industrial2of5
>7. Export the batch
>8. You should have a white page with no barcode
>     And errors in the relevant log file
>     "Invalid Characters"
>     This is the bug.
>9. Layout: set "Barcode type:" to COOP2of5
>10. Export the batch
>11. You should have a white page with no barcode
>      And errors in the relevant log file
>      "Invalid Characters"
>      This is the bug.
>12. Apply this patch
>13. Retry with both non-working patches
>    1. You should have a white page with a barcode
>    2. And no errors in the relevant log file
>---
> C4/Patroncards/Patroncard.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Patroncards/Patroncard.pm b/C4/Patroncards/Patroncard.pm
>index 3229559..559d10d 100644
>--- a/C4/Patroncards/Patroncard.pm
>+++ b/C4/Patroncards/Patroncard.pm
>@@ -394,7 +394,7 @@ sub _draw_barcode {   # this is cut-and-paste from Label.pm because there is no
>             PDF::Reuse::Barcode::COOP2of5(
>                 x                   => $params{'llx'}* $self->{'unitvalue'},
>                 y                   => $params{'lly'}* $self->{'unitvalue'},
>-                value               => "*$params{barcode_data}*",
>+                value               => $params{barcode_data},
>                 xSize               => $x_scale_factor,
>                 ySize               => $params{'y_scale_factor'},
>                 mode                    => 'graphic',
>@@ -412,7 +412,7 @@ sub _draw_barcode {   # this is cut-and-paste from Label.pm because there is no
>             PDF::Reuse::Barcode::Industrial2of5(
>                 x                   => $params{'llx'}* $self->{'unitvalue'} ,
>                 y                   => $params{'lly'}* $self->{'unitvalue'},
>-                value               => "*$params{barcode_data}*",
>+                value               => $params{barcode_data},
>                 xSize               => $x_scale_factor,
>                 ySize               => $params{'y_scale_factor'},
>                 mode                    => 'graphic',
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 20084: 70913 | 70914 | 76760 | 76883