Attachment 70972 Details for Bug 20088 – Bug 20088: Fix uninitialized warning from svc/holds

[patch] Bug 20088: Fix uninitialized warning from svc/holds

Bug-20088-Fix-uninitialized-warning-from-svcholds.patch (text/plain), 1.27 KB, created by Nick Clemens (kidclamp) on 2018-01-26 18:42:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2018-01-26 18:42:15 UTC

Size: 1.27 KB

patch

obsolete

>From c12e365f0cd540b7d9ea7e7b6ee970b10389045a Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 25 Jan 2018 12:01:30 +0100
>Subject: [PATCH] Bug 20088: Fix uninitialized warning from svc/holds
>
>Use of uninitialized value in array element at svc/holds line 56.
>
>Test plan:
>Check if the warn is no longer in the logs; the warning is triggered by
>an ajax call from the circulation template in staff.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> svc/holds | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/svc/holds b/svc/holds
>index 5c0ed35..062109d 100755
>--- a/svc/holds
>+++ b/svc/holds
>@@ -54,8 +54,8 @@ my $borrowernumber    = $input->param('borrowernumber');
> my $offset            = $input->param('iDisplayStart');
> my $results_per_page  = $input->param('iDisplayLength');
> my $sorting_direction = $input->param('sSortDir_0') || 'desc';
>-my $sorting_column    = $sort_columns[ $input->param('iSortCol_0') ]
>-  || 'reservedate';
>+my $iSortCol          = $input->param('iSortCol_0') // 0;
>+my $sorting_column    = $sort_columns[$iSortCol] // 'reservedate';
> 
> binmode STDOUT, ":encoding(UTF-8)";
> print $input->header( -type => 'text/plain', -charset => 'UTF-8' );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20088: 70912 | 70922 | 70972