Attachment 71074 Details for Bug 20104 – Bug 20104: Update minimum version of Perl to 5.20

[patch] Bug 20104: Update minimum version of Perl to 5.20

Bug-20104-Update-minimum-version-of-Perl-to-520.patch (text/plain), 2.07 KB, created by Mark Tompsett on 2018-01-30 19:58:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2018-01-30 19:58:28 UTC

Size: 2.07 KB

patch

obsolete

>From 5064eab58d6df790c3f44d6ae760aca6979e4930 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Tue, 30 Jan 2018 19:53:32 +0000
>Subject: [PATCH] Bug 20104: Update minimum version of Perl to 5.20
>
>This patch not only updates the version check, but repurposes
>the perlversion parameter, so as to not have to retranslate
>templates again when the version number changes after this.
>
>The changes are very self-evident.
>---
> installer/install.pl                                       | 4 ++--
> koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/installer/install.pl b/installer/install.pl
>index a7aaa28..c132939 100755
>--- a/installer/install.pl
>+++ b/installer/install.pl
>@@ -93,8 +93,8 @@ if ( $step && $step == 1 ) {
>     $template->param( 'checkmodule' => 1 )
>       ; # we start with the assumption that there are no problems and set this to 0 if there are
> 
>-    unless ( $] >= 5.010000 ) {    # Bug 7375
>-        $template->param( problems => 1, perlversion => 1, checkmodule => 0 );
>+    unless ( $] >= 5.020000 ) {    # Bug 20104
>+        $template->param( problems => 1, perlversion => '5.20', checkmodule => 0 );
>         $checkmodule = 0;
>     }
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt
>index 806f28e..7cebfa8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt
>@@ -70,7 +70,7 @@
>                         <p>I encountered some problems.</p>
>                         <ul>
>                             [% IF ( perlversion ) %]
>-                                <li>Your Perl version is out of date. Please upgrade to a newer version of Perl (at least version 5.10).</li>
>+                                <li>Your Perl version is out of date. Please upgrade to a newer version of Perl (at least version [% perlversion %]).</li>
>                             [% END %]
>                         </ul>
>                     [% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20104: 71074 | 73806 | 73829