Attachment 71169 Details for Bug 20060 – Bug 20060: Resolve uninitialized warn from Koha::Template::Plugin::Branches

[patch] Bug 20060: Resolve uninitialized warn from Koha::Template::Plugin::Branches

Bug-20060-Resolve-uninitialized-warn-from-KohaTemp.patch (text/plain), 1.26 KB, created by Katrin Fischer on 2018-02-04 11:21:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2018-02-04 11:21:57 UTC

Size: 1.26 KB

patch

obsolete

>From da166cf5faddf0485e951da7a7d8bfc320f411b8 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 22 Jan 2018 13:04:33 +0100
>Subject: [PATCH] Bug 20060: Resolve uninitialized warn from
> Koha::Template::Plugin::Branches
>
>The warn comes from undefined C4::Context->userenv->{branch}.
>Can be triggered by calling mainpage.pl when being logged out in staff.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> Koha/Template/Plugin/Branches.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Template/Plugin/Branches.pm b/Koha/Template/Plugin/Branches.pm
>index edbad11b02..8c4bb14d74 100644
>--- a/Koha/Template/Plugin/Branches.pm
>+++ b/Koha/Template/Plugin/Branches.pm
>@@ -66,7 +66,7 @@ sub all {
> 
>     for my $l ( @$libraries ) {
>         if (       defined $selected and $l->{branchcode} eq $selected
>-            or not defined $selected and C4::Context->userenv and $l->{branchcode} eq C4::Context->userenv->{branch}
>+            or not defined $selected and C4::Context->userenv and $l->{branchcode} eq ( C4::Context->userenv->{branch} // q{} )
>         ) {
>             $l->{selected} = 1;
>         }
>-- 
>2.14.1

Actions: View | Diff | Splinter Review

Attachments on bug 20060: 70793 | 71078 | 71169