Attachment 71170 Details for Bug 20109 – Bug 20109: Allow translating "Remove" in Add Fund

[patch] Bug 20109: Allow translating "Remove" in Add Fund

Bug-20109-Allow-translating-Remove-in-Add-Fund.patch (text/plain), 2.01 KB, created by Katrin Fischer on 2018-02-04 11:32:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2018-02-04 11:32:32 UTC

Size: 2.01 KB

patch

obsolete

>From fea91f4be9c5ad6c3c6931a91599d73c7e30a241 Mon Sep 17 00:00:00 2001
>From: Pasi Kallinen <pasi.kallinen@joensuu.fi>
>Date: Wed, 31 Jan 2018 08:51:30 +0200
>Subject: [PATCH] Bug 20109: Allow translating "Remove" in Add Fund
>
>When a user has been added to the fund, the link to "Remove" that user
>is not translatable.
>
>Test plan:
>
>1) Install language xx-YY
>2) Go to Home -> Administration -> Budgets -> Funds -> Add Fund
>3) Add a user to the fund
>4) Notice how the "Remove" link after the user's name is not translated
>5) Apply patch
>6) Look in xx-YY-staff-prog.po, and if needed, translate the msgid
>   "Remove"
>7) Update and reinstall the language
>8) Do 2 and 3 again. The "Remove" link should now be translated.
>
>Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>https://bugs.koha-community.org/show_bug.cgi?id=10209
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
>index 21a3877b6a..943e28e84b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
>@@ -491,7 +491,7 @@
>                     var li = '<li id="user_' + borrowernumber + '">'
>                         + '<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber='
>                         + borrowernumber + '">' + borrowername + '</a> '
>-                        + ' &bull; <a data-borrowernumber=" + borrowernumber +" class="del_user" href="#"><i class="fa fa-trash"></i> Remove</a> '
>+                        + ' &bull; <a data-borrowernumber=" + borrowernumber +" class="del_user" href="#"><i class="fa fa-trash"></i> '+_('Remove')+'</a> '
>                         + '</li>';
>                     $("#budget_users").prepend(li);
>                     ids.push(borrowernumber);
>-- 
>2.14.1

Actions: View | Diff | Splinter Review

Attachments on bug 20109: 71079 | 71088 | 71170 | 71224