Bugzilla – Attachment 71243 Details for
Bug 10032
Uncertain prices hide 'close basket' without explanation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10032: (follow-up) Move title attribute to button container
Bug-10032-follow-up-Move-title-attribute-to-button.patch (text/plain), 2.19 KB, created by
Katrin Fischer
on 2018-02-06 07:14:07 UTC
(
hide
)
Description:
Bug 10032: (follow-up) Move title attribute to button container
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-02-06 07:14:07 UTC
Size:
2.19 KB
patch
obsolete
>From 2fb1c9e71a599558cb7917265db7415708651ab5 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 4 Jan 2018 14:16:42 +0000 >Subject: [PATCH] Bug 10032: (follow-up) Move title attribute to button > container > >This patch modifies the "Close basket" button markup so that the title >attribute on a disabled button is added to the button wrapper <div> >instead of the <a> tag. This allows the title attribute tooltip to >appear when the cursor is hovered over the button. > >To test, follow the original patch's test plan and confirm that when the >"Close basket" button is disabled, hovering the mouse over the button >triggers the title attribute tooltip. > >Signed-off-by: Charlotte Cordwell <charlotte.cordwell123@gmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 775df53..804d165 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -62,8 +62,8 @@ > [% IF ( unclosable ) %] > [% ELSIF ( uncertainprices ) %] > <div class="btn-group"><a href="/cgi-bin/koha/acqui/uncertainprice.pl?booksellerid=[% booksellerid %]&owner=1" class="btn btn-default btn-sm" id="uncertpricesbutton"><i class="fa fa-usd"></i> Uncertain prices</a></div> >- <div class="btn-group"> >- <a href="" class="btn btn-default btn-sm disabled" id="closebutton" title="Can not close baskets that have items with uncertain prices in them."><i class="fa fa-times-circle"></i> Close this basket</a> >+ <div title="Can not close baskets that have items with uncertain prices in them." class="btn-group"> >+ <a href="" class="btn btn-default btn-sm disabled" id="closebutton"><i class="fa fa-times-circle"></i> Close this basket</a> > </div> > [% ELSE %] > <div class="btn-group"> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10032
:
17375
|
69748
|
70250
|
70272
|
70526
|
70527
|
71242
| 71243