Bugzilla – Attachment 71273 Details for
Bug 20148
Don't allow adding same user multiple times to a basket or an order
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20148: Adding same user multiple times to acq basket
0001-Bug-20148-Adding-same-user-multiple-times-to-acq-bas.patch (text/plain), 1.44 KB, created by
paxed
on 2018-02-07 07:55:40 UTC
(
hide
)
Description:
Bug 20148: Adding same user multiple times to acq basket
Filename:
MIME Type:
Creator:
paxed
Created:
2018-02-07 07:55:40 UTC
Size:
1.44 KB
patch
obsolete
>From 876a11e56c4aa9d0ff943f424661a8dddab01f15 Mon Sep 17 00:00:00 2001 >From: Pasi Kallinen <pasi.kallinen@joensuu.fi> >Date: Wed, 7 Feb 2018 09:45:20 +0200 >Subject: [PATCH] Bug 20148: Adding same user multiple times to acq basket > >When adding a user to manage acquisitions basket, it is possible >to add the same user multiple times. Prevent that. > >Test plan: > >1) Go to Home -> Acquisitions -> [bookseller] -> [basket] >2) On the "Add user" in the Managed by-part, and try adding > the same user multiple times. >3) Apply patch >4) Repeat 1 and 2. You should now get an error message saying > the user is already in the list. > >Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 81d07ff34e..e6288ff8e5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -815,7 +815,7 @@ > } else { > ids = new Array; > } >- if (ids.indexOf(borrowernumber) < 0) { >+ if (ids.indexOf(borrowernumber.toString()) < 0) { > ids.push(borrowernumber); > $("#users_ids").val(ids.join(':')); > var li = '<li id="user_'+borrowernumber+'">'+borrowername >-- >2.11.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20148
:
71273
|
71862
|
71863
|
71898
|
71899
|
71915