Bugzilla – Attachment 71292 Details for
Bug 19641
Move patron templates JavaScript to the footer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19641: (Follow-up) Fix update child menu option
Bug-19641-Follow-up-Fix-update-child-menu-option.patch (text/plain), 1.96 KB, created by
Josef Moravec
on 2018-02-07 16:37:14 UTC
(
hide
)
Description:
Bug 19641: (Follow-up) Fix update child menu option
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-02-07 16:37:14 UTC
Size:
1.96 KB
patch
obsolete
>From 820be374a22bffeeb9df5aa7023075abb924820a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 26 Jan 2018 13:12:16 +0000 >Subject: [PATCH] Bug 19641: (Follow-up) Fix update child menu option > >This follow-up corrects handling of clicks on the "Update child" menu >option when the patron is an adult. Previously the click handler was >conditionally added via template markup. This patch modifies it to use >the data-tooltip attribute as an indicator that the option is disabled. > >To test, apply the patch and clear your browser cache if necessary. > >- Open an adult patron's record for viewing. >- Choose More -> Update child from the toolbar menu. >- The menu item should be disabled, and should show a tooltip. >- Clicking the menu item should do nothing. > >- Open a child patron's record for viewing. >- Choose More -> Update child from the toolbar menu. >- The patron should be updated to an adult category. > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> > >https://bugs.koha-community.org/show_bug.cgi?id=19682 >--- > koha-tmpl/intranet-tmpl/prog/js/members-menu.js | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/members-menu.js b/koha-tmpl/intranet-tmpl/prog/js/members-menu.js >index b2b105d..675f643 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/members-menu.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/members-menu.js >@@ -57,9 +57,13 @@ $(document).ready(function(){ > $(".btn-group").removeClass("open"); > return false; > }); >- $("#updatechild").click(function(){ >- update_child(); >- $(".btn-group").removeClass("open"); >+ $("#updatechild").click(function(e){ >+ if( $(this).data("toggle") == "tooltip"){ // Disabled menu option has tooltip attribute >+ e.preventDefault(); >+ } else { >+ update_child(); >+ $(".btn-group").removeClass("open"); >+ } > }); > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19641
:
69200
|
69415
|
70428
|
70429
|
70433
|
70720
|
70723
|
70724
|
70725
|
70726
|
70953
|
71289
|
71290
|
71291
| 71292 |
71676
|
71677