Attachment 71299 Details for Bug 20155 – [SIGNED-OFF] Bug 20155 - Improve readability of OPAC header language menu

[patch] [SIGNED-OFF] Bug 20155 - Improve readability of OPAC header language menu

SIGNED-OFF-Bug-20155---Improve-readability-of-OPAC.patch (text/plain), 8.27 KB, created by Jon Knight on 2018-02-07 18:23:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jon Knight

Created: 2018-02-07 18:23:40 UTC

Size: 8.27 KB

patch

obsolete

>From b54b36ab2b10874ca418c4b08e1f52aac5092b2c Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 7 Feb 2018 17:17:34 +0000
>Subject: [PATCH] [SIGNED-OFF] Bug 20155 - Improve readability of OPAC header
> language menu
>
>This patch makes some minor HTML and CSS changes in order to make the
>header's language-chooser menu more readable and consistent with the
>Lists menu.
>
>To test, apply this patch and the patch with the compiled CSS.
>
>- Install and enable more than one translation.
>- Set the OpacLangSelectorMode to either "top" or "both top and footer."
>- View the OPAC's header menu and confirm that the links and menus look
> correct whether or not a user is logged in.
>
>Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
>---
> .../opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc | 6 +++---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 10 +++++-----
> koha-tmpl/opac-tmpl/bootstrap/less/opac.less | 8 ++++++--
> 3 files changed, 14 insertions(+), 10 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc
>index a5f8aa2..7ba9054 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc
>@@ -9,9 +9,9 @@
> [% FOREACH sublanguages_loo IN languages_loo.sublanguages_loop %]
> [% IF ( sublanguages_loo.enabled ) %]
> [% IF ( sublanguages_loo.sublanguage_current ) %]
>- <li role="presentation"> <a href="#" tabindex="-1" class="menu-inactive" role="menuitem">[% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %]&nbsp;</a></li>
>+ <li role="presentation"> <a href="#" tabindex="-1" role="menuitem">[% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %]&nbsp;</a></li>
> [% ELSE %]
>- <li role="presentation"><a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% sublanguages_loo.rfc4646_subtag %]" tabindex="-1" role="menuitem" class="listmenulink"> [% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %]</a></li>
>+ <li role="presentation"><a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% sublanguages_loo.rfc4646_subtag %]" tabindex="-1" role="menuitem"> [% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %]</a></li>
> [% END %]
> [% END # / IF sublanguages_loo.enabled %]
> [% END # / FOREACH sublanguages_loo %]
>@@ -20,7 +20,7 @@
> [% IF ( languages_loo.current ) %]
> <li role="presentation"><a href="#" tabindex="-1" class="menu-inactive" role="menuitem">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]&nbsp;</a></li>
> [% ELSE %]
>- <li role="presentation"><a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% languages_loo.rfc4646_subtag %]" tabindex="-1" role="menuitem" class="listmenulink">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</a></li>
>+ <li role="presentation"><a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% languages_loo.rfc4646_subtag %]" tabindex="-1" role="menuitem">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</a></li>
> [% END %]
> [% END # / IF languages_loo.current %]
> [% END # / IF ( languages_loo.plural ) %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>index fd37f6e..ec27e97 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>@@ -95,20 +95,20 @@
> [% UNLESS ( loggedinusername ) %]
> [% IF Koha.Preference('casAuthentication') %]
> [%# CAS authentication is too complicated for modal window %]
>- <li><a href="/cgi-bin/koha/opac-user.pl">Log in to your account</a></li>
>+ <li><a class="login-link" href="/cgi-bin/koha/opac-user.pl">Log in to your account</a></li>
> [% ELSIF ( Koha.Preference('GoogleOpenIDConnect') == 1 ) %]
>- <li><a href="/cgi-bin/koha/svc/auth/googleopenidconnect" role="button" data-toggle="modal">Log in to your account</a></li>
>+ <li><a class="login-link" href="/cgi-bin/koha/svc/auth/googleopenidconnect" role="button" data-toggle="modal">Log in to your account</a></li>
> [% ELSE %]
>- <li><a href="/cgi-bin/koha/opac-user.pl" class="loginModal-trigger" role="button" data-toggle="modal">Log in to your account</a></li>
>+ <li><a href="/cgi-bin/koha/opac-user.pl" class="login-link loginModal-trigger" role="button" data-toggle="modal">Log in to your account</a></li>
> [% END %]
> [% END %]
> [% IF ( loggedinusername ) %]
>- <li>Welcome, <a href="/cgi-bin/koha/opac-user.pl">[% USER_INFO.title %] [% USER_INFO.firstname %] [% USER_INFO.surname %]</a></li>
>+ <li>Welcome, <a class="login-link" href="/cgi-bin/koha/opac-user.pl">[% USER_INFO.title %] [% USER_INFO.firstname %] [% USER_INFO.surname %]</a></li>
> <li class="divider-vertical"></li>
> [% END %]
> [% END %]
> [% IF EnableOpacSearchHistory %]
>- <li><a href="/cgi-bin/koha/opac-search-history.pl" title="View your search history">Search history</a> [<a class="logout clearsh" href="/cgi-bin/koha/opac-search-history.pl?action=delete" title="Delete your search history">x</a>]</li>
>+ <li><a class="login-link" href="/cgi-bin/koha/opac-search-history.pl" title="View your search history">Search history</a> [<a class="logout clearsh" href="/cgi-bin/koha/opac-search-history.pl?action=delete" title="Delete your search history">x</a>]</li>
> <li class="divider-vertical"></li>
> [% END %]
> [% IF Koha.Preference( 'opacuserlogin' ) == 1 %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/less/opac.less b/koha-tmpl/opac-tmpl/bootstrap/less/opac.less
>index 8423e6c..3cbfdb8 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/less/opac.less
>+++ b/koha-tmpl/opac-tmpl/bootstrap/less/opac.less
>@@ -70,6 +70,10 @@ a {
> color : #FFF;
> }
> }
>+ &.login-link {
>+ color: #A6D8ED;
>+ font-weight: bold;
>+ }
> }
> 
> .ui-widget-content a,
>@@ -184,14 +188,14 @@ td {
> color : #EEE;
> }
> a {
>- color: #A6D8ED;
>- font-weight: bold;
> &.logout {
> color : #E8583C;
>+ font-weight: bold;
> padding : 0 .3em 0 .3em;
> }
> }
> }
>+
> #koha_url p {
> color: #666666;
> float : right;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20155: 71294 | 71295 | 71299 | 71300 | 71330 | 71331