Attachment 71328 Details for Bug 19451 – Bug 19451: (QA follow-up) Change parameter name no_overwrite to no-overwrite for consistency

[patch] Bug 19451: (QA follow-up) Change parameter name no_overwrite to no-overwrite for consistency

Bug-19451-QA-follow-up-Change-parameter-name-noove.patch (text/plain), 1.62 KB, created by Josef Moravec on 2018-02-07 21:14:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2018-02-07 21:14:12 UTC

Size: 1.62 KB

patch

obsolete

>From 2dd5723d2c0bc6427fcca417d5b098a70d690a26 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Wed, 7 Feb 2018 21:06:10 +0000
>Subject: [PATCH] Bug 19451: (QA follow-up) Change parameter name no_overwrite
> to no-overwrite for consistency
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> misc/maintenance/borrowers-force-messaging-defaults.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/misc/maintenance/borrowers-force-messaging-defaults.pl b/misc/maintenance/borrowers-force-messaging-defaults.pl
>index 4a1f42d..2daa8b7 100755
>--- a/misc/maintenance/borrowers-force-messaging-defaults.pl
>+++ b/misc/maintenance/borrowers-force-messaging-defaults.pl
>@@ -81,7 +81,7 @@ my $result = GetOptions(
>     'truncate'    => \$truncate,
>     'since:s'     => \$since,
>     'not-expired' => \$not_expired,
>-    'no_overwrite'  => \$no_overwrite,
>+    'no-overwrite'  => \$no_overwrite,
>     'help|h'      => \$help,
> );
> 
>@@ -111,7 +111,7 @@ Filled' notice for example.
> 
> This script creates/overwrites messaging preferences for all borrowers and sets
> them to default values defined for the category they belong to (unless you
>-use the options -not-expired or -no_overwrite to update a subset).
>+use the options -not-expired or -no-overwrite to update a subset).
> 
> =over 8
> 
>@@ -132,7 +132,7 @@ affects borrower_message_preferences table.
> 
> Will only update active borrowers (borrowers who didn't pass their expiration date).
> 
>-=item B<--no_overwrite>
>+=item B<--no-overwrite>
> 
> Will only update patrons without messaging preferences and skip patrons that
> already set their preferences.
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19451: 67989 | 68200 | 68844 | 71327 | 71328 | 71367